src: fix to use replacement character

PR-URL: nodejs/node#43999 Fixes: nodejs/node#43962 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Feng Yu <[email protected]>
noslate-project · Jan 3, 2023 · 1ede51d · 1ede51d
1 parent d0ea683
commit 1ede51d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/node_i18n.cc b/src/node_i18n.cc
@@ -425,7 +425,11 @@ void ConverterObject::Create(const FunctionCallbackInfo<Value>& args) {
                         nullptr, nullptr, nullptr, &status);
   }
 
-  new ConverterObject(env, obj, conv, flags);
+  auto converter = new ConverterObject(env, obj, conv, flags);
+  size_t sublen = ucnv_getMinCharSize(conv);
+  std::string sub(sublen, '?');
+  converter->set_subst_chars(sub.c_str());
+
   args.GetReturnValue().Set(obj);
 }
 

diff --git a/test/parallel/test-whatwg-encoding-custom-textdecoder.js b/test/parallel/test-whatwg-encoding-custom-textdecoder.js
@@ -199,3 +199,10 @@ if (common.hasIntl) {
   const str = decoder.decode(chunk);
   assert.strictEqual(str, 'foo\ufffd');
 }
+
+if (common.hasIntl) {
+  const decoder = new TextDecoder('Shift_JIS');
+  const chunk = new Uint8Array([-1]);
+  const str = decoder.decode(chunk);
+  assert.strictEqual(str, '\ufffd');
+}