-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add toYaml and fromYaml to functions map #176
Conversation
Hiya @norwoodj , can you approve my CI when you get time? Thanks |
I would love to see those functions, as they were used a lot by the k8s-at-home guys in their charts (which are deprecated, so I forked some and noticed the missing functions...) |
This would be amazing. There's also a PR to add this in Masterminds/sprig#360 |
@Nepo26 Need anything from me to move this? |
Honestly, only chart examples in the |
@jasondamour Agreeing with @Nepo26, if you add an example chart that uses these, and a test case, we'll merge. |
hello, this look fantastic, may I help? |
I love you :-) I can add an example and some tests, here my readme_template, to display storage class:
This work like a charm! |
I'm confused, you've added examples, but not the code from this PR. Did you generate the README in the example you included using the version of helm-docs from this PR? |
yes exactly! I dont have write access to this PR fork, to avoid a PR of PR ^^ I prefer create the PR here. |
Adds
toYaml
andfromYaml
functions from helm src