Pre commit.com 559

[jrottenberg]

To work toward completion of pre-commit/pre-commit.com#559

[armsnyder]

Do we assume all of these examples are generated using the same helm-docs arguments? I recently added an example in a PR #112 where I used a --document-dependency-vlaues arg.

[jrottenberg]

Comment on the wrong PR ?

[jrottenberg]

@norwoodj @skang0601 any feedback ?

[skang0601]

@jrottenberg Sorry I'm not too familiar with the language config and what it's doing here.

So this executes a go get when a user uses this hook?

[jrottenberg]

Yep exactly, I've kept the original hook, since it is in used already (and popular), just adding the ability to install the hook and have it execute properly even if you don't have the tool installed , as long as you have golang toolchains (pre-commit does the install and cache under tho hood)

Did a quick demo :
asciinema play -i 0.1 https://asciinema.org/a/443563

I've edited the output of cat .pre-commit-config.yaml in the demo but that's the only thing doctored, I've figured it would be a nice addition to the README to show how pre-commit works.

[skang0601]

Thanks! That's super cool to learn about. Then this LGTM, I'll go ahead and merge it in.