-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add attempt to require bluebird first #3
Add attempt to require bluebird first #3
Conversation
i had it this way before. unfortunately, if we added this back, we would have to change the name of the module =P |
people can vote on this though... don't really care |
I had the same thought :P but I think it's fine, people are probably going after functionality and performance rather than the actual order of events. |
@jonathanong would it make sense to allow some option like I'm particularly interested in experimenting the new unhandled rejection tracking support on io.js and bluebird already has hooks for that. |
i'm ambivalent. anyone care about this? |
@jonathanong agree! Native Promise has memory gc reason and current can't be fix tj/co#180 . |
or new module name bluebird-or-native ... |
@fengmk2 good reason! |
1.2.0! |
haha. I always do |
This is likely controversial, but in my opinion, if a developer has
bluebird
installed, we might as well take advantage of that fact, at least for now, considering that it is 40x faster than ES6 Promises.See https://github.com/petkaantonov/bluebird/tree/master/benchmark and angular/angular.js#6697 (comment).
We can always switch back to the previous order when ES6 Promises are optimized in V8. I've tested the benchmarks on io.js and even with the V8 upgrade, native promises are still way slower than bluebird's implementation.