fix parentheses colors in js template strings #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcticicestudio
requested changes
Jun 22, 2020
There was a problem hiding this comment.
Hi @kufii 👋, thanks for your contribution 👍
Sorry for this delay, the amount of issues & PRs for Nord is large.
I've tested the changes and it works fine, but I've added a suggestion to ensure it's also compatible with the most popular JavaScript syntax highlighting extension which unfortunately requires additional scope selectors.
arcticicestudio
added
scope-compatibility
status-review
and removed
status-requires-review
labels
Even though this is a extension specific addition, this is necessary since `mgmcdermott.vscode-language-babel` [1] is the most popular extension for _JavaScript_ syntax highlighting. [1]: https://marketplace.visualstudio.com/items?itemName=mgmcdermott.vscode-language-babel Co-authored-by: Arctic Ice Studio <[email protected]>
svengreb
approved these changes
Jun 23, 2020
arcticicestudio
approved these changes
Jun 23, 2020
arcticicestudio
pushed a commit
that referenced
this pull request
Feb 1, 2021
Improved the highlighting of braces within JavaScript template literals [1] to use `nord4` as foreground color instead of `nord14` like strings. [1]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals Co-authored-by: Arctic Ice Studio <[email protected]> Co-authored-by: Sven Greb <[email protected]> Resolves GH-162
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #162