nord.tmux: Make script portable #96
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed bashisms that made the file unable to be run by tmux on systems where `/bin/sh` is a symlink to `dash`. Shell commands in `tmux` are `sh` commands. It only worked if your system symlinked `/bin/sh` to `bash`. To make the file even more POSIX-compliant, we would have to remove the `local` variable assignments on lines 29-31, but `dash` supports these builtins, so this should be fine. I used the tool `checkbashisms` on Arch Linux to locate the issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed bashisms that made the file unable to be run by tmux on systems where
/bin/shis a symlink todash. Shell commands intmuxareshcommands. It only worked if your system symlinked/bin/shtobash.To make the file even more POSIX-compliant, we would have to remove the
localvariable assignments on lines 29-31, butdashsupports these builtins, so this should be fine.I used the tool
checkbashismson Arch Linux to locate the issues.