added borderless setting #181
Conversation
|
Unsure on what I should do in this scenario though, thoughts? |
|
Leave as it is for now, it was merged by a mistake and soon we'll fix it. |
|
what was merged by mistake? |
|
The top url bar, we knew it didnt look right. Will work on a fix later today |
|
ahh got it. I'll rebase off dev once it's been pushed then 👀 |
Hey! Ya, it actually ain't sitting right. Since it was an alpha, I had just implemented it that way. I'm already working on making it better. Made some progress on it. Will make a fix for that and send PR. |
|
pinging to keep this active. I would like to postulate--borderless settings ONLY allowable for default sidebar view. Could fix the UI question for topbar. |
|
@jonathancaudill That's what I was thinking too. If the topbar is enabled, we go back to having the rounded and contained style. I can update the PR if we like that idea 👀 |
|
@hackr-sh sorry for the late response. I think that's a great strategy. If you wanna update the PR to match and have no conflicts I'll merge it over as soon as I can! |
hackr-sh
force-pushed
the
feat/borderless
branch
from
f574029 to
3907553
Compare
|
Thanks for your work to bring up to date!! Will look at tomorrow and merge! |
|
Hey! sorry, it's not just done yet - I accidentally got side tracked but I just need to optionally remove the upper and lower borders |
4 participants
This just adds a borderless toggle in the settings!
(I know it's not really true to Arc since Arc never allowed 0 border but I've been loving this in Zen Browser for months now and I thought "I know Swift, let me make a PR and see if it gets approved!")