NC | GPFS | Threaded Multiple Object Delete fix #8388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romayalon
force-pushed
the
romy-threaded-multi-object-delete
branch
from
16cd2e8
to
b4b2968
Compare
nadavMiz
reviewed
Sep 22, 2024
romayalon
force-pushed
the
romy-threaded-multi-object-delete
branch
from
b4b2968
to
0799b8c
Compare
guymguym
reviewed
Sep 22, 2024
2 tasks
|
@romayalon could you please add the issue you opened on the Ceph S3 tests |
2 tasks
romayalon
force-pushed
the
romy-threaded-multi-object-delete
branch
2 times, most recently
from
f65e5c1
to
15c3ac3
Compare
Signed-off-by: Romy <[email protected]>
romayalon
force-pushed
the
romy-threaded-multi-object-delete
branch
from
15c3ac3
to
110abc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx
s3tests_boto3/functional/test_s3.py::test_versioning_concurrent_multi_object_delete, currently it's not working because they call put bucket twice and the test fails on BucketAlreadyExists, the test I added dooes the same as the ceph test but in general we want to remove it from the pending list. Opened a bug - test_versioning_concurrent_multi_object_delete creates the bucket twice and fails on BucketAlreadyExists ceph/s3-tests#588.Testing Instructions:
sudo jest -t 'concurrent multi object delete'on GPFS cluster or runs3tests_boto3/functional/test_s3.py::test_versioning_concurrent_multi_object_deletewhile fixing manually the bug on s3-tests code - see the suggested fix in test_versioning_concurrent_multi_object_delete creates the bucket twice and fails on BucketAlreadyExists ceph/s3-tests#588.