Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFS | GPFS | fix put object over null version in suspended mode #8386

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

nadavMiz
Copy link
Contributor

@nadavMiz nadavMiz commented Sep 19, 2024

Explain the changes

  1. on Suspeded mode we need to delete the latest null version if a new object is created (as there can be only one object with null version). this delete fails on GPFS since we use the wrong gps_options. however since in GPFS link overrides existing file anyway, we don't need to call unlink at all in such scenario. changed so unlink will not be called to delete latest null version on Suspended mode for GPFS
  2. add missing use of gpfs_options.delete_version instead of gpfs_options for deleting old null version

Issues: Fixed #8379

Testing Instructions:

Run test_nsfs_versioning_gpfs.js tests on gpfs cluster

  • Doc added/updated
  • Tests added

src/sdk/namespace_fs.js Outdated Show resolved Hide resolved
src/sdk/namespace_fs.js Outdated Show resolved Hide resolved
src/sdk/namespace_fs.js Outdated Show resolved Hide resolved
src/sdk/namespace_fs.js Outdated Show resolved Hide resolved
@nadavMiz nadavMiz force-pushed the put-object-null-suspended branch 2 times, most recently from 99ab82c to f944c29 Compare September 19, 2024 15:21
src/sdk/namespace_fs.js Outdated Show resolved Hide resolved
@nadavMiz nadavMiz force-pushed the put-object-null-suspended branch 6 times, most recently from d4da795 to ab82fcb Compare September 24, 2024 07:31
@pull-request-size pull-request-size bot added size/S and removed size/M labels Sep 24, 2024
@nadavMiz nadavMiz merged commit 00a44f4 into noobaa:master Sep 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NSFS | S3 | Versioning: InternalError upon PutObject over existing key in version-suspended bucket
2 participants