5.17 Backports #8383
Merged
5.17 Backports #8383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elete-marker 1. In namespace_fs add the case of specific version to the error that is thrown with additional information that we will use to set headers in the http response. To support it I added the params argument to the function _throw_if_delete_marker. 2. In s3_error add the mapping between the rpc that we used in namespace_fs and the S3 error that we want it to be mapped. 3. In s3_rest change the s3err.rpc_data to err.rpc_data since the object s3error does not have the rpc_data as a property inside it. Add the case to set http header for the delete-marker, reuse this change in a refactored function _prepare_error. Signed-off-by: shirady <[email protected]> (cherry picked from commit 8492113)
1. Add tests to run in the CI. Signed-off-by: shirady <[email protected]> (cherry picked from commit fdca4c1)
Signed-off-by: nadav mizrahi <[email protected]> (cherry picked from commit b744060)
Signed-off-by: Romy <[email protected]> (cherry picked from commit d1c3f68)
1. Moved tests of features that are not supported in NSFS from nsfs_s3_tests_pending_list (tests of supported features that we want to investigate in the future) to nsfs_s3_tests_black_list (tests of unsupported features that fail and we don't need to investigate) - those tests include the following names: - post_object - test_lifecycle (except test_lifecycle_get_no_id and test_lifecycle_set) - object_lock_ - test_sse - test_cors Signed-off-by: shirady <[email protected]> (cherry picked from commit abd0db6)
Signed-off-by: nadav mizrahi <[email protected]> (cherry picked from commit 6ffaa8a)
1. Change the calls of native_fs_utils.safe_unlink that are used gpfs_options as it was received from _open_files_gpfs which can return an object with property delete_version or an object with 2 properties move_to_versions and move_to_dst, hence when using this returned object to the function native_fs_utils.safe_unlink the argument gpfs_options should an object with the properties src_file and dir_file. Signed-off-by: shirady <[email protected]> (cherry picked from commit c65039b)
Signed-off-by: shirady <[email protected]> (cherry picked from commit f0f8899)
Signed-off-by: nadav mizrahi <[email protected]> (cherry picked from commit 088a25f)
liranmauda
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: