Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NC | NSFS | Versioning | Delete Objects | Add a Test | GPFS #8371

Merged
merged 1 commit into from
Sep 18, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/test/unit_tests/test_nsfs_versioning_gpfs.js
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,16 @@ mocha.describe('namespace_fs gpfs- versioning', async function() {
assert.equal(delete_res.version_id, put_res2.version_id);
});

mocha.it('delete objects - versioning enabled - use delete_multiple_objects to delete a single non-existing key', async function() {
// 1. put bucket versioning enabled
await ns_obj.set_bucket_versioning('ENABLED', dummy_object_sdk);
// 2. delete objects (a single non existing key)
const objects = [{ key: 'non-existing-key', version_id: undefined }];
const delete_objects_res = await delete_multiple_objects(dummy_object_sdk, ns_obj, gpfs_bucket, objects);
assert.equal(delete_objects_res.created_delete_marker, true);
assert.ok(delete_objects_res.created_version_id !== undefined);
});

});

async function put_object(dummy_object_sdk, ns, bucket, key) {
Expand Down Expand Up @@ -241,6 +251,15 @@ async function delete_object(dummy_object_sdk, ns, bucket, key, version_id) {
return delete_res;
}

async function delete_multiple_objects(dummy_object_sdk, ns, bucket, objects) {
const delete_objects_res = await ns.delete_multiple_objects({
bucket,
objects
}, dummy_object_sdk);
console.log('delete_multiple_objects response', util.inspect(delete_objects_res));
return delete_objects_res;
}


async function stat_and_get_all(full_path, key) {
const key_path = path.join(full_path, key);
Expand Down