Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSFS | Delete object version id concurrency #8367

Merged
merged 1 commit into from
Sep 17, 2024
Merged

NSFS | Delete object version id concurrency #8367

merged 1 commit into from
Sep 17, 2024

Conversation

romayalon
Copy link
Contributor

Explain the changes

  1. Added missing try catch for skipping ENOENT on unlink of a version id on delete object version id.
  2. Added a concurrency unit test.

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  1. sudo jest --testRegex=jest_tests/test_versioning_conc
  • Doc added/updated
  • Tests added

shirady
shirady approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@shirady shirady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/sdk/namespace_fs.js Outdated Show resolved Hide resolved
@romayalon romayalon force-pushed the romy-concurrent-delete-version-id branch from 5afcd72 to 1436a00 Compare September 17, 2024 07:22
@pull-request-size pull-request-size bot added size/M and removed size/S labels Sep 17, 2024
shirady
shirady approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@shirady shirady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/util/native_fs_utils.js Outdated Show resolved Hide resolved
@romayalon romayalon force-pushed the romy-concurrent-delete-version-id branch from 1436a00 to 8e90461 Compare September 17, 2024 07:32
@romayalon romayalon force-pushed the romy-concurrent-delete-version-id branch from 8e90461 to d1c3f68 Compare September 17, 2024 09:09
@romayalon romayalon merged commit 4a116e5 into noobaa:master Sep 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirady shirady shirady approved these changes

@nadavMiz nadavMiz Awaiting requested review from nadavMiz

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romayalon @shirady