NSFS | fix copy_object issues #8355
Conversation
nadavMiz
force-pushed
the
fix_copy_object
branch
from
5f95df5
to
829dd08
Compare
nadavMiz
force-pushed
the
fix_copy_object
branch
from
829dd08
to
0fa8a6e
Compare
src/test/system_tests/ceph_s3_tests/s3-tests-lists/nsfs_s3_tests_pending_list.txt
Show resolved
Hide resolved
nadavMiz
force-pushed
the
fix_copy_object
branch
from
0fa8a6e
to
c02f990
Compare
nadavMiz
force-pushed
the
fix_copy_object
branch
4 times, most recently
from
04322a4
to
71c4943
Compare
nadavMiz
force-pushed
the
fix_copy_object
branch
from
71c4943
to
c12aae9
Compare
There was a problem hiding this comment.
@nadavMiz I think it looks OK, but due to the sensitivity I still pointed two things for @romayalon and @nimrod-becker to notice, so would be good to check with them
| @@ -1373,13 +1369,6 @@ class NamespaceFS { | |||
| return upload_info; | |||
| } | |||
|
|
|||
| async _get_copy_source_xattr(params, fs_context, fs_xattr) { | |||
There was a problem hiding this comment.
@romayalon can you please review this removal - this is based on the fact that we already handle this for all cases in object_sdk fix_copy_source_params (look for source_md.xattr).
There was a problem hiding this comment.
I have reviewed it with @romayalon seems like this was added by mistake
| if (target_ns instanceof NamespaceFS) { | ||
| params.source_ns = actual_source_ns; | ||
| params.source_params = source_params; | ||
| } else { | ||
| //this._populate_nsfs_copy_fallback({ source_params, source_ns, params }); | ||
| throw new Error('TODO fix _populate_nsfs_copy_fallback'); |
There was a problem hiding this comment.
@nimrod-becker @romayalon please notice that in this PR we only fixed the copy between nsfs and another nsfs bucket, but copy between nsfs and other namespace types is throwing for now - it should be fixed in a followup PR.
There was a problem hiding this comment.
I have opened a follow up issue #8372
Signed-off-by: nadav mizrahi <[email protected]>
nadavMiz
force-pushed
the
fix_copy_object
branch
from
c12aae9
to
b744060
Compare
Explain the changes
Issues: Fixed #8315
Testing Instructions: