NC | NSFS | Versioning | Fix Bug 8333 | Delete Object with Version ID | GPFS

[shirady]

Explain the changes

1. Change the calls of native_fs_utils.safe_unlink that are used gpfs_options as it was received from _open_files_gpfs which can return an object with property delete_version or an object with 2 properties move_to_versions and move_to_dst, hence when using this returned object to the function native_fs_utils.safe_unlink the argument gpfs_options should an object with the properties src_file and dir_file.

Issues: Fixed #8333

1. Currently, on GPFS when using the delete-object with version ID there is an error, in the logs, we can see:

core.util.native_fs_utils:: safe_unlink: dir_file is undefined, cannot use it to call safe_unlink_gpfs

Testing Instructions:

1. Not yet, it Should be tested on a GPFS machine.

• Doc added/updated
• Tests added

[romayalon]

LGTM, but let's not merge it until it's tested on GPFS

[romayalon]

@shirady can you add a test to test_nsfs_versioning_gpfs.js?

[shirady]

Validation on GPFS cluster:

I used this RPM: noobaa-core-5.18.0-20240917-nsfs-nc-versioning-fixes.el9.x86_64.rpm
Which was created from this branch: nsfs-nc-versioning-fixes

Cluster node:

1. We created an account using noobaa-cli: noobaa-cli account add --name s3user-5001 --uid 5001 --gid 5001 --new_buckets_path /ibm/fs1/teams/ (note new_buckets_path is running on GPFS, you can run df -T /ibm/fs1/teams/)

Client node:
2. Created the alias s3-u1='AWS_ACCESS_KEY_ID=<access-key> AWS_SECRET_ACCESS_KEY=<secret-key> aws --no-verify-ssl --endpoint https://1<ip-address-of-node>:6443/ --no-verify-ssl'
3. create a bucket: s3-u1 s3 mb s3://user-5001-b02; echo $?

make_bucket: user-5001-b02
0

4. versioning enabled: s3-u1 s3api put-bucket-versioning --bucket user-5001-b02 --versioning-configuration Status=Enabled and then s3-u1 s3api get-bucket-versioning --bucket user-5001-b02

{
    "Status": "Enabled"
}

5. put an object (save the version-id): s3-u1 s3api put-object --bucket user-5001-b02 --key hello.txt

{
    "ETag": "\"mtime-d49fqckqr9c0-ino-1r7l\"",
    "VersionId": "mtime-d49fqckqr9c0-ino-1r7l"
}

6. delete object with version-id: s3-u1 s3api delete-object --bucket user-5001-b02 --key hello.txt --version-id <version-id>

{
    "VersionId": "mtime-d49fqckqr9c0-ino-1r7l"
}

From the logs (/var/log/messages): You can see the return code 204 (success)

Sep 18 06:14:41 tmtscalets-protocol-1 node[1501925]: Sep-18 6:14:41.486 [nsfs/1501925] [L1] core.util.http_utils:: HTTP REPLY EMPTY DELETE /user-5001-b02/hello.txt?versionId=mtime-d49fqckqr9c0-ino-1r7l (removed from printing) 204

Outputs are as expected, no errors.
@romayalon @nadavMiz