Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport to 5.15] upgrade to node 20.9.0. ignore deprecated warnings to make nan compile #7669

Merged
merged 1 commit into from
Dec 20, 2023
Merged

[Backport to 5.15] upgrade to node 20.9.0. ignore deprecated warnings to make nan compile #7669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.18.2
20.9.0
2 changes: 2 additions & 0 deletions src/native/common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
'-Wextra',
'-Werror',
'-Wpedantic',
#Can be removed when https://github.com/nodejs/nan/issues/953 is resolved.
'-Wno-error=deprecated-declarations'
],
# see https://nodejs.org/docs/latest-v12.x/api/process.html#process_process_arch
# Possible values are:
Expand Down
Loading