Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data_compressed test failing #13

Closed
Alberdi opened this issue Apr 5, 2023 · 1 comment · Fixed by #14
Closed

data_compressed test failing #13

Alberdi opened this issue Apr 5, 2023 · 1 comment · Fixed by #14
Assignees
Labels
bug Something isn't working

Comments

@Alberdi
Copy link
Member

Alberdi commented Apr 5, 2023

%%% nbson_SUITE ==> data_compressed: FAILED
%%% nbson_SUITE ==> {{badmatch,[#{<<"compressed">> =>
                  {data,compressed,
                        <<31,139,8,0,0,0,0,0,0,3,43,201,200,44,86,0,162,68,
                          133,146,212,138,18,0,33,62,234,238,14,0,0,0>>}}]},
 [{nbson_SUITE,data_compressed,1,
               [{file,"/Users/marcelino/Developer/nbson/test/nbson_SUITE.erl"},
                {line,123}]},
  {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
  {test_server,run_test_case_eval1,6,[{file,"test_server.erl"},{line,1291}]},
  {test_server,run_test_case_eval,9,[{file,"test_server.erl"},{line,1223}]}]}

It seems like there's a small difference between the expected and the returned value:

[#{<<"compressed">> =>
           {data,compressed,
-                   <<31,139,8,0,0,0,0,0,0,19,43,201,200,44,86,0,162,68,133,
+                   <<31,139,8,0,0,0,0,0,0,3,43,201,200,44,86,0,162,68,133,
                    146,212,138,18,0,33,62,234,238,14,0,0,0>>}}]

Tested both on Erlang 25.0.3 and 25.3.

@LoisSotoLopez
Copy link
Contributor

As pointed by @Alberdi , by taking a look at nodejs/node#12244 the solution might be matching the OS code byte with an empty variable.

@Alberdi Alberdi self-assigned this Apr 5, 2023
@Alberdi Alberdi added the bug Something isn't working label Apr 5, 2023
Alberdi added a commit that referenced this issue Apr 5, 2023
Alberdi added a commit that referenced this issue May 12, 2023
Alberdi added a commit that referenced this issue May 12, 2023
* fix(#13): data_compressed test failing

Also update ssh-agent and checkout versions.

Closes #13.
Alberdi added a commit that referenced this issue Feb 8, 2024
* fix(#13): data_compressed test failing

Also update ssh-agent and checkout versions.

Closes #13.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants