Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: map scheme, host and port from elli #75

Closed
albertocsouto opened this issue Jul 2, 2024 · 0 comments · Fixed by #76
Closed

feat: map scheme, host and port from elli #75

albertocsouto opened this issue Jul 2, 2024 · 0 comments · Fixed by #76
Assignees
@albertocsouto
Labels
enhancement New feature or request

Comments

@albertocsouto
Copy link
Contributor

albertocsouto commented Jul 2, 2024 •
edited
Loading

Current erf implementation is hiding the values included in elli request scheme, host and port:

https://github.com/elli-lib/elli/blob/main/include/elli.hrl

Mapping doesn't work quite well for localhost, due an elli limitation:
elli-lib/elli#83

Maybe fixed if maintainer greenlights release 4.0.0:
elli-lib/elli#110
@albertocsouto albertocsouto self-assigned this Jul 2, 2024
@github-project-automation github-project-automation bot moved this to 📑 TODO in erf Jul 2, 2024
@albertocsouto albertocsouto added the enhancement New feature or request label Jul 2, 2024
albertocsouto added a commit that referenced this issue Jul 2, 2024
@albertocsouto
feat(#75) map scheme, host and port
f3a8d31
@albertocsouto albertocsouto mentioned this issue Jul 2, 2024
Merged
javiergarea pushed a commit that referenced this issue Aug 15, 2024
@albertocsouto
feat(#75) map scheme, host and port (#76)
66c5c03
@github-project-automation github-project-automation bot moved this from 📑 TODO to 🎉 Done in erf Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@albertocsouto albertocsouto

Labels
enhancement New feature or request
Projects
erf
Status: 🎉 Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(#75) map scheme, host and port nomasystems/erf
1 participant
@albertocsouto