fix(minimax): narrow image error-body except to JSON decode failures - #32
Closed
blackflame007 wants to merge 1 commit into
Closed
fix(minimax): narrow image error-body except to JSON decode failures#32blackflame007 wants to merge 1 commit into
blackflame007 wants to merge 1 commit into
Conversation
Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The strict-rule gate on #31 failed with
BLE001: total 2899 over limit 2898pointing atMinimaxImageGenerationConfig._error_message_from_body, but #31 was squash-merged before the fix could land on its branch, so the blindexcept Exceptionis now onlitellm_internal_stagingand every subsequent PR inherits the over-budget total. This narrows the catch to the JSON decode failures the helper actually guards against, matchingMinimaxVideoConfig._error_message_from_body:httpx.Response.json()raisesjson.JSONDecodeError(aValueErrorsubclass) on a non-JSON body, so the HTML-502 path this helper exists for keeps returningraw_response.textand behavior is unchanged.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is enabled.