Skip to content

upgrade to svelte 2.0#251

Merged
nolanlawson merged 2 commits intomasterfrom
svelte-2.0-take-two
May 2, 2018
Merged

upgrade to svelte 2.0#251
nolanlawson merged 2 commits intomasterfrom
svelte-2.0-take-two

Conversation

@nolanlawson
Copy link
Owner

After incrementally removing some deprecated stuff, let's see if this works...

@nolanlawson
Copy link
Owner Author

Hmmm, production mode is still failing for some reason, apparently due to CSS. Need to debug...

@nolanlawson
Copy link
Owner Author

Seems Svelte 2.0 changed how CSS is emitted? For some reason, async CSS chunks just aren't generated at all. 😕

@nolanlawson
Copy link
Owner Author

Oddly, sometimes the npm run build command fails entirely:

ERROR in /private/var/folders/3x/d09_d8b15tn8yvg8_18pm8200000gn/T/svelte-undefined.css
Module build failed: ModuleBuildError: Module build failed: Unclosed comment (2:1)

@nolanlawson
Copy link
Owner Author

Tried disabling source maps. Still succeeds in building occasionally, but when it does there are no async CSS chunks. When it fails it shows an error like this:

ERROR in /private/var/folders/3x/d09_d8b15tn8yvg8_18pm8200000gn/T/svelte-undefined.css
Module build failed: ModuleBuildError: Module build failed: SyntaxError: Unexpected token  in JSON at position 1273

@nolanlawson
Copy link
Owner Author

The CSS file svelte-undefined.css appears valid, but that name is probably wrong

@nolanlawson
Copy link
Owner Author

It looks like all CSS files are being generated with the filename svelte-undefined.css.

@nolanlawson
Copy link
Owner Author

Ah just found this exact issue: sveltejs/svelte-loader#56

screenshot 2018-05-01 08 28 42

@nolanlawson
Copy link
Owner Author

overall JS bundle size drops from 642kB to 615kB, very nice! http://dev.pinafore.social/report.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant