Skip to content

test: isolate integration suite XDG state - #1911

Merged
SequeI merged 4 commits into
mainfrom
improveTests
Sep 14, 2026
Merged

SequeI merged 4 commits into
mainfrom
improveTests

Conversation

@SequeI

@SequeI SequeI commented Sep 14, 2026

Copy link
Copy Markdown
Member

Linked Issue

Closes #1732

Summary

Test Plan

Checklist

  • An issue exists and is linked above
  • All commits are signed-off, using DCO
  • All new code follows the project's coding standards (CLAUDE.md) and is covered by tests
  • Public-facing changes are paired with documentation updates
  • If this PR introduces a major feature, capability, or security-relevant change, a corresponding NEP has been opened or accepted and is linked

Signed-off-by: Aleksy Siek <aleksy@nolabs.ai>
@github-actions github-actions Bot added test Test additions or changes nono-cli size/medium labels Sep 14, 2026
@github-actions

github-actions Bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

PR Review Summary

Size

Metric Value
Lines added +131
Lines removed -100
Total changed 231
Classification Medium (50–300 lines)

Affected crates

  • crates/nono-cli — CLI changes. Verify argument parsing, flag documentation, and UX behaviour across supported platforms.

Blast radius — Moderate

This PR touches: source code,CI / build tooling


Updated automatically on each push to this PR.

@nogent-nolabs-ai nogent-nolabs-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nogent code review

No blocking issues; 0 findings.

Findings: none flagged in scope.

Automated code + security review. CI already covers clippy, rustfmt, tests, cargo-audit and commit-lint.

Signed-off-by: Aleksy Siek <aleksy@nolabs.ai>
Signed-off-by: Aleksy Siek <aleksy@nolabs.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

nono-cli size/medium test Test additions or changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky integration suite: Child / Tool Boundaries intermittently fails, passes on rerun

2 participants