Repository navigation
fix(cgroup): skip control files when sweeping stale lineage sessions - #1802
Merged
Merged
Conversation
teardown_session_tree read_dir a session cgroup dir and rmdir every entry, including the cgroups own control/pseudo-files (memory.events, pids.peak, io.latency, ...), not just the cmd_* child cgroups it meant to remove. rmdir on those files fails with ENOTDIR, logging spurious "could not remove cgroup leaf" warnings on every stale-session sweep. Filter to cmd_-prefixed entries only, matching CMD_PREFIX used elsewhere in this file. Signed-off-by: Aleksy Siek <aleksy@nolabs.ai>
Contributor
PR Review SummarySize
Affected crates
Blast radius — ContainedThis PR touches: source code Updated automatically on each push to this PR. |
Member
Author
|
@icydipity let me know if this works please! Worked on my repro |
lukehinds
approved these changes
Sep 7, 2026
Yes, this worked. Thanks for the fix! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #1793
Summary
teardown_session_tree read_dir a session cgroup dir and rmdir every entry, including the cgroups own control/pseudo-files (memory.events, pids.peak, io.latency, ...), not just the cmd_* child cgroups it meant to remove. rmdir on those files fails with ENOTDIR, logging spurious "could not remove cgroup leaf" warnings on every stale-session sweep.
Filter to cmd_-prefixed entries only, matching CMD_PREFIX used elsewhere in this file.
Test Plan
Checklist