Repository navigation
fix(proxy): disable audit buffer for standalone nono proxy - #1766
Merged
SequeI merged 1 commit intoSep 1, 2026
Merged
Conversation
Standalone \`nono proxy\` has no rollback consumer to drain audit events, so the 4096-event ring buffer fills up and logs \"audit buffer full\" on every subsequent request. PR nolabs-ai#1682 introduced \`enable_network_audit\` to disable the buffer but explicitly left the standalone path unchanged. Set \`proxy_config.enable_network_audit = false\` in \`run_proxy\` alongside the other standalone-specific overrides. Remove the 30-second periodic drain loop that was compensating for the missing flag. Closes nolabs-ai#1501 Signed-off-by: Leonardo Zanivan <leonardo.zanivan@gmail.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Leonardo Zanivan <leonardo.zanivan@gmail.com>
Contributor
PR Review SummarySize
Affected crates
Blast radius — ContainedThis PR touches: source code Updated automatically on each push to this PR. |
nono proxy\nono proxy
SequeI
approved these changes
Sep 1, 2026
SequeI
left a comment
Member
There was a problem hiding this comment.
lgtm! I need to get into the habit of remembering standalone proxy now exists..
levonk
pushed a commit
to levonk/nono
that referenced
this pull request
Sep 4, 2026
…s-ai#1766) Standalone \`nono proxy\` has no rollback consumer to drain audit events, so the 4096-event ring buffer fills up and logs \"audit buffer full\" on every subsequent request. PR nolabs-ai#1682 introduced \`enable_network_audit\` to disable the buffer but explicitly left the standalone path unchanged. Set \`proxy_config.enable_network_audit = false\` in \`run_proxy\` alongside the other standalone-specific overrides. Remove the 30-second periodic drain loop that was compensating for the missing flag. Closes nolabs-ai#1501 Signed-off-by: Leonardo Zanivan <leonardo.zanivan@gmail.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #1501
Summary
nono proxy(standalone mode) logsaudit buffer fullon every request once the4096-event ring buffer fills. The buffer exists only for rollback audit recording; the
standalone path has no rollback consumer and no code that drains it.
PR #1682 introduced
enable_network_audit/--no-auditto disable the buffer on thenono runpath, but its description explicitly noted standalonenono proxywas leftunchanged. A 30-second periodic drain loop was added as a workaround in
proxy_command.rs, but in any burst-traffic window the buffer still fills and thewarning fires within that window.
Fix: set
proxy_config.enable_network_audit = falseinrun_proxyalongside theother standalone-specific overrides (
bind_addr,require_auth,max_connections,etc.). Remove the drain loop, which existed solely to compensate for the missing flag.
Agent Disclosure (if applicable)
This PR is generated by an AI agent (Claude). Files consulted:
crates/nono-cli/src/proxy_command.rs,crates/nono-proxy/src/config.rs,crates/nono-proxy/src/server.rs,crates/nono-cli/src/launch_runtime.rs.The change is scoped to the standalone
nono proxycommand path and does not affectsandboxed
nono run/nono shell/nono wrapflows. Confirmed compliance withrepository coding and security requirements: no
unwrap/expect, uses existingNonoError, no path handling involved.Test Plan
Checklist