Skip to content

fix(proxy): disable audit buffer for standalone nono proxy - #1766

Merged
SequeI merged 1 commit into
nolabs-ai:mainfrom
panga:fix/standalone-proxy-audit-buffer-warnings
Sep 1, 2026
Merged

SequeI merged 1 commit into
nolabs-ai:mainfrom
panga:fix/standalone-proxy-audit-buffer-warnings

Conversation

@panga

@panga panga commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Linked Issue

Closes #1501

Summary

nono proxy (standalone mode) logs audit buffer full on every request once the
4096-event ring buffer fills. The buffer exists only for rollback audit recording; the
standalone path has no rollback consumer and no code that drains it.

PR #1682 introduced enable_network_audit / --no-audit to disable the buffer on the
nono run path, but its description explicitly noted standalone nono proxy was left
unchanged. A 30-second periodic drain loop was added as a workaround in
proxy_command.rs, but in any burst-traffic window the buffer still fills and the
warning fires within that window.

Fix: set proxy_config.enable_network_audit = false in run_proxy alongside the
other standalone-specific overrides (bind_addr, require_auth, max_connections,
etc.). Remove the drain loop, which existed solely to compensate for the missing flag.

Agent Disclosure (if applicable)

This PR is generated by an AI agent (Claude). Files consulted:
crates/nono-cli/src/proxy_command.rs, crates/nono-proxy/src/config.rs,
crates/nono-proxy/src/server.rs, crates/nono-cli/src/launch_runtime.rs.

The change is scoped to the standalone nono proxy command path and does not affect
sandboxed nono run/nono shell/nono wrap flows. Confirmed compliance with
repository coding and security requirements: no unwrap/expect, uses existing
NonoError, no path handling involved.

Test Plan

# Build
make build-cli

# Existing tests pass
make test-cli

# Manual: drive high request volume through standalone proxy, confirm no warnings
nono proxy &
for i in $(seq 1 200); do
  curl -s -x http://localhost:<port> http://example.com -o /dev/null
done
# Expect: no "WARN nono_proxy::server: audit buffer full" lines in output

Checklist

  • An issue exists and is linked above
  • All commits are signed-off, using DCO
  • All new code follows the project's coding standards (CLAUDE.md) and is covered by tests
  • Public-facing changes are paired with documentation updates
  • If this PR introduces a major feature, capability, or security-relevant change, a corresponding NEP has been opened or accepted and is linked

Standalone \`nono proxy\` has no rollback consumer to drain audit events,
so the 4096-event ring buffer fills up and logs \"audit buffer full\" on
every subsequent request. PR nolabs-ai#1682 introduced \`enable_network_audit\` to
disable the buffer but explicitly left the standalone path unchanged.

Set \`proxy_config.enable_network_audit = false\` in \`run_proxy\` alongside
the other standalone-specific overrides. Remove the 30-second periodic
drain loop that was compensating for the missing flag.

Closes nolabs-ai#1501

Signed-off-by: Leonardo Zanivan <leonardo.zanivan@gmail.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Leonardo Zanivan <leonardo.zanivan@gmail.com>
@github-actions github-actions Bot added bug Something isn't working nono-cli size/small labels Sep 1, 2026
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

PR Review Summary

Size

Metric Value
Lines added +7
Lines removed -22
Total changed 29
Classification Small (< 50 lines)

Affected crates

  • crates/nono-cli — CLI changes. Verify argument parsing, flag documentation, and UX behaviour across supported platforms.

Blast radius — Contained

This PR touches: source code


Updated automatically on each push to this PR.

@nogent-nolabs-ai nogent-nolabs-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nogent code review

No blocking issues; 0 findings.

Findings: none flagged in scope.

Automated code + security review. CI already covers clippy, rustfmt, tests, cargo-audit and commit-lint.

@panga panga changed the title fix(proxy): disable audit buffer for standalone \nono proxy\ fix(proxy): disable audit buffer for standalone nono proxy Sep 1, 2026

@SequeI SequeI left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! I need to get into the habit of remembering standalone proxy now exists..

@SequeI
SequeI merged commit d3c6f6b into nolabs-ai:main Sep 1, 2026
22 checks passed
levonk pushed a commit to levonk/nono that referenced this pull request Sep 4, 2026
…s-ai#1766)

Standalone \`nono proxy\` has no rollback consumer to drain audit events,
so the 4096-event ring buffer fills up and logs \"audit buffer full\" on
every subsequent request. PR nolabs-ai#1682 introduced \`enable_network_audit\` to
disable the buffer but explicitly left the standalone path unchanged.

Set \`proxy_config.enable_network_audit = false\` in \`run_proxy\` alongside
the other standalone-specific overrides. Remove the 30-second periodic
drain loop that was compensating for the missing flag.

Closes nolabs-ai#1501

Signed-off-by: Leonardo Zanivan <leonardo.zanivan@gmail.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working nono-cli size/small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

long sessions spam WARN to console

2 participants