fix(audit): propogate errors after unparseable ledger - #1596
Open
kurtisc wants to merge 3 commits into
Open
Conversation
Contributor
PR Review SummarySize
Affected crates
Blast radius — ContainedThis PR touches: source code Updated automatically on each push to this PR. |
4 tasks
kurtisc
force-pushed
the
kurtisc/audit-unparseable
branch
from
August 7, 2026 14:59
9db242d to
05d3567
Compare
kurtisc
force-pushed
the
kurtisc/audit-unparseable
branch
from
August 7, 2026 15:00
05d3567 to
352313d
Compare
kurtisc
force-pushed
the
kurtisc/audit-unparseable
branch
from
August 7, 2026 15:02
352313d to
e9e52a5
Compare
Contributor
Author
|
Trying out stacked PRs |
kurtisc
force-pushed
the
kurtisc/audit-unparseable
branch
from
August 7, 2026 15:25
e9e52a5 to
50e5439
Compare
kurtisc
force-pushed
the
kurtisc/audit-unparseable
branch
from
August 7, 2026 17:55
50e5439 to
ca76e24
Compare
kurtisc
force-pushed
the
kurtisc/audit-unparseable
branch
from
August 7, 2026 18:53
ca76e24 to
f215496
Compare
kurtisc
force-pushed
the
kurtisc/audit-unparseable
branch
from
August 7, 2026 19:03
f215496 to
07a2dfb
Compare
kurtisc
force-pushed
the
kurtisc/audit-unparseable
branch
from
August 7, 2026 19:11
07a2dfb to
8803e8b
Compare
kurtisc
force-pushed
the
kurtisc/audit-unparseable
branch
from
August 7, 2026 19:17
8803e8b to
934d9a0
Compare
kurtisc
force-pushed
the
kurtisc/audit-unparseable
branch
from
August 10, 2026 11:41
934d9a0 to
302eda3
Compare
kurtisc
marked this pull request as ready for review
August 10, 2026 11:41
![nogent-nolabs-ai[bot]](https://avatars.githubusercontent.com/in/4165202?s=60&v=4){kind=small}
Adds an integration test for a global audit ledger holding two records on one line. Refs: #1583 Signed-off-by: Kurtis Charnock <kurtis@nolabs.ai>
Reports session finalisation errors on stderr so child processes' exit codes can be bubbled up. Refs: #1583 Signed-off-by: Kurtis Charnock <kurtis@nolabs.ai>
Reports ledger append errors locally so audit shipping and rollback review aren't skipped. Fixes: #1583 Signed-off-by: Kurtis Charnock <kurtis@nolabs.ai>
kurtisc
force-pushed
the
kurtisc/audit-unparseable
branch
from
August 10, 2026 14:12
302eda3 to
08dba91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #1583
Summary
Keeps child processes' exit codes past finalisation and reports errors after this stage locally.
Warns instead of aborting when a ledger append is skipped.
Doesn't attempt to fix corrupted ledgers.
Test Plan
New integration test + steps to reproduce
Checklist