fix(tool-sandbox): clean up runtime dir with sealed shims - #1492
Merged
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Contributor
PR Review SummarySize
Affected crates
Blast radius — ContainedThis PR touches: source code Updated automatically on each push to this PR. |
kipz
marked this pull request as ready for review
July 23, 2026 13:35
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
kipz
added a commit
to kipz/nono
that referenced
this pull request
Jul 23, 2026
kipz
added a commit
to kipz/nono
that referenced
this pull request
Jul 23, 2026
Signed-off-by: James Carnegie <me@kipz.org>
kipz
force-pushed
the
kipz/tool-sandbox-dir-leak
branch
from
July 24, 2026 15:31
b72dfc3 to
4181ab8
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #1491
Summary
The per-invocation tool-sandbox runtime directory leaked on every run. Its
shims/subdirectory is sealed to0o500, andguarded_remove_runtime_dircalledfs::remove_dir_allwithout restoring write on it — so unlinking the sealed shim copies failed withEACCESand the whole tree was left behind (the error was only logged atdebug). This restores owner-write recursively across the runtime tree before removal, on macOS and Linux, without changing the sealing behaviour itself.Agent Disclosure (if applicable)
crates/nono-cli/src/tool-sandbox/mod.rs,.../platform/macos.rs,.../platform/linux.rs.unwrap/expect,NonoErrorused, symlinks never followed during the chmod walk.Test Plan
guarded_remove_deletes_runtime_dir_with_sealed_shims): seals ashims/dir and asserts the runtime dir is removed. Verified it fails without the fix and passes with it.make ci(clippy-D warnings, fmt-check, tests, doc lint) clean.nono-tool-sandbox-*residue (previously leaked on every run).Checklist
CHANGELOG.mdif neededAgent Compliance Check (Required for AI/Automated PRs)