ci(release): add macos code signing and notarization - #1483
Merged
Conversation
This commit introduces the necessary steps for macOS code signing and notarization within the release workflow. - The `nono` binary is now signed with an Apple Developer ID certificate. - The signed binary is submitted to Apple's Notarization Service. This is a requirement for distributing macOS software outside the Mac App Store, allowing it to pass Gatekeeper checks without security warnings. - A temporary keychain is created for certificate import and is securely deleted upon completion, even if subsequent steps fail. - The `codesign` and `notarytool` utilities are used to perform these operations. Signed-off-by: Luke Hinds <lukehinds@gmail.com>
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Contributor
PR Review SummarySize
Affected cratesNo crate source directories are directly affected. Blast radius — ContainedThis PR touches: CI / build tooling Updated automatically on each push to this PR. |
![nogent-nolabs-ai[bot]](https://avatars.githubusercontent.com/in/4165202?s=60&v=4){kind=small}
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces the necessary steps for macOS code signing and notarization within the release workflow.
nonobinary is now signed with an Apple Developer ID certificate.codesignandnotarytoolutilities are used to perform these operations.Linked Issue #1224
@panga 👀