fix(session): route attach socket through symlink - #1477
Merged
Conversation
Contributor
PR Review SummarySize
Affected crates
Blast radius — ContainedThis PR touches: source code Updated automatically on each push to this PR. |
Addresses the socket through a short per-user directory symlink (<XDG_RUNTIME_DIR|/tmp>/nono-<uid>-<hash>) so the sun_path stays in bounds, while the socket inode still lives at the canonical path. Adds tests covering the over-limit bind/connect round-trip and the link creation, reuse, stale-replacement, and refusal paths. Signed-off-by: Kurtis Charnock <kurtis@nono.ai>
kurtisc
force-pushed
the
kurtisc/deep-path
branch
from
July 22, 2026 12:16
ea54068 to
701dcde
Compare
kurtisc
marked this pull request as ready for review
July 22, 2026 12:16
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #1465
Summary
Routes attach sockets through a symlink to avoid paths which are too long (i.e. >SUN_LEN)
Test Plan
Checklist
CHANGELOG.mdif needed