fix(diagnostic): replace deprecated nono learn with nono run - #1170
Conversation
PR Review SummarySize
Affected crates
Blast radius — ContainedThis PR touches: source code Updated automatically on each push to this PR. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the diagnostic formatter to suggest using nono run --allow <path> instead of the deprecated nono learn command when displaying next steps for sandbox denials or application errors. The corresponding documentation comments and unit tests have been updated to reflect this change. No review comments were provided, so there is no additional feedback to address.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
b631643 to
cb2be37
Compare
Signed-off-by: connrg <conor@alwaysfurther.ai>
…ai#1170) Signed-off-by: connrg <conor@alwaysfurther.ai>
Deprecated in v0.52.0 and superseded by nono runs built-in deny-and- suggest flow (#1170). Removes learn.rs, learn_runtime.rs, LearnArgs, the Commands::Learn dispatch path, dead constants in timeouts.rs, and get_system_read_paths from policy.rs. Signed-off-by: Aleksy Siek <aleksy@alwaysfurther.ai>
* chore: remove deprecated nono learn command Deprecated in v0.52.0 and superseded by nono runs built-in deny-and- suggest flow (#1170). Removes learn.rs, learn_runtime.rs, LearnArgs, the Commands::Learn dispatch path, dead constants in timeouts.rs, and get_system_read_paths from policy.rs. Signed-off-by: Aleksy Siek <aleksy@alwaysfurther.ai> * review fixes Signed-off-by: Aleksy Siek <aleksy@alwaysfurther.ai> * review fixes Signed-off-by: Aleksy Siek <aleksy@alwaysfurther.ai> --------- Signed-off-by: Aleksy Siek <aleksy@alwaysfurther.ai>
2 participants
Diagnostic footer suggests
nono learnwhich was deprecated in v0.50.1. Users following the suggestion hit a dead end. Replaced withnono run --allow <path>so the guidance points to anactual next action.