feat(update-check): discover ci environments on update - #1113
Merged
Conversation
The update check now includes a coarse classification of the CI environment. This helps us understand how nono well (or not) recent versions are used in automated workflows versus local development. - Detection relies solely on well-known environment variable names (e.g., GITHUB_ACTIONS, CI). - Raw environment variable values are never collected or transmitted. - The update service's privacy assurances remain unchanged: no personally identifiable information is collected. - Updated the `test-update-server.py` script to log the new CI fields. Signed-off-by: Luke Hinds <lukehinds@gmail.com>
The `CiEnvironment` struct has been removed to streamline the representation of CI detection. The `detect_ci_environment` function has been renamed to `detect_ci_provider` and now directly returns an `Option<&'static str>` representing the detected CI provider. This simplifies the API by removing the need for an explicit `is_ci` boolean, as its presence can be inferred from `ci_provider.is_some()`. New tests have been added to: - Ensure that environment variables with "falsey" values (e.g., empty string, "0") do not inadvertently trigger CI detection. - Validate that no CI is detected when no relevant environment variables are present. Signed-off-by: Luke Hinds <lukehinds@gmail.com>
Contributor
PR Review SummarySize
Affected crates
Blast radius — ContainedThis PR touches: source code Updated automatically on each push to this PR. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds CI environment classification to the update check request, allowing the CLI to detect and report the CI provider (e.g., GitHub Actions, GitLab CI, etc.) using environment variables. It also updates the local test update server and adds comprehensive unit tests. The review feedback suggests simplifying the env_marker_present helper function by using std::env::var directly instead of std::env::var_os and to_string_lossy(), and recommends treating additional values like "off" and "no" as falsey to improve robustness.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
SequeI
approved these changes
Jun 11, 2026
Contributor
|
Looks good to me, just need to resolve the gemini recommendation |
oscarmackjr-twg
pushed a commit
to OscarMackJr/nono
that referenced
this pull request
Jun 23, 2026
* feat(update-check): discover ci environments on update The update check now includes a coarse classification of the CI environment. This helps us understand how nono well (or not) recent versions are used in automated workflows versus local development. - Detection relies solely on well-known environment variable names (e.g., GITHUB_ACTIONS, CI). - Raw environment variable values are never collected or transmitted. - The update service's privacy assurances remain unchanged: no personally identifiable information is collected. - Updated the `test-update-server.py` script to log the new CI fields. Signed-off-by: Luke Hinds <lukehinds@gmail.com> * refactor(update_check): simplify ci environment detection The `CiEnvironment` struct has been removed to streamline the representation of CI detection. The `detect_ci_environment` function has been renamed to `detect_ci_provider` and now directly returns an `Option<&'static str>` representing the detected CI provider. This simplifies the API by removing the need for an explicit `is_ci` boolean, as its presence can be inferred from `ci_provider.is_some()`. New tests have been added to: - Ensure that environment variables with "falsey" values (e.g., empty string, "0") do not inadvertently trigger CI detection. - Validate that no CI is detected when no relevant environment variables are present. Signed-off-by: Luke Hinds <lukehinds@gmail.com> --------- Signed-off-by: Luke Hinds <lukehinds@gmail.com> Co-authored-by: Aleks <121458075+SequeI@users.noreply.github.com> (cherry picked from commit cc11b38) Signed-off-by: oscarmackjr-twg <oscar.mack.jr@gmail.com>
klassm
pushed a commit
to klassm/nono
that referenced
this pull request
Jul 3, 2026
* feat(update-check): discover ci environments on update The update check now includes a coarse classification of the CI environment. This helps us understand how nono well (or not) recent versions are used in automated workflows versus local development. - Detection relies solely on well-known environment variable names (e.g., GITHUB_ACTIONS, CI). - Raw environment variable values are never collected or transmitted. - The update service's privacy assurances remain unchanged: no personally identifiable information is collected. - Updated the `test-update-server.py` script to log the new CI fields. Signed-off-by: Luke Hinds <lukehinds@gmail.com> * refactor(update_check): simplify ci environment detection The `CiEnvironment` struct has been removed to streamline the representation of CI detection. The `detect_ci_environment` function has been renamed to `detect_ci_provider` and now directly returns an `Option<&'static str>` representing the detected CI provider. This simplifies the API by removing the need for an explicit `is_ci` boolean, as its presence can be inferred from `ci_provider.is_some()`. New tests have been added to: - Ensure that environment variables with "falsey" values (e.g., empty string, "0") do not inadvertently trigger CI detection. - Validate that no CI is detected when no relevant environment variables are present. Signed-off-by: Luke Hinds <lukehinds@gmail.com> --------- Signed-off-by: Luke Hinds <lukehinds@gmail.com> Co-authored-by: Aleks <121458075+SequeI@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide improved classification of nono running in a CI environment. This helps us understand how nono well is (or is not) set to run recent versions in automated workflows versus local development.
test-update-server.pyscript to log the new CI fields.Signed-off-by: Luke Hinds lukehinds@gmail.com