Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing limits header #119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bradh
Copy link

@bradh bradh commented Apr 12, 2023

During testing of #118, I hit an error about numeric_limits not being part of std.

This was on Ubuntu Linux with g++ 11.3.0.

During testing of nokiatech#118, I hit an error about numeric_limits not being part of std. This was on Ubuntu Linux with g++ 11.3.0.
@unrealslayer
Copy link

unrealslayer commented Oct 6, 2023

same on ubuntu 22, clang 18, header 'limits' missing
merge this fix pls!

@tyano461
Copy link

A similar build error occurred in a fedora39 & gcc-c++ environment.
And by applying this fix the build was successful.

@cylindrical2002
Copy link

why there is no one merge the code?

@bradh
Copy link
Author

bradh commented Feb 10, 2025

why there is no one merge the code?

I think the research team has moved on. Sometime teams don't stay around to maintain code - they have other work, change task priority. Maybe that is the case here.

I don't ever expect this to be merged. I just left this open so you can apply it yourself if you need it.

@NicTanghe
Copy link

NicTanghe commented Feb 11, 2025

Hmm ok It's an important enough library though.
how does the community normally go about heralding a fork as the new official maintained thing.
I guess it doesn't get enough use in this form to get enough traction to do that ?

I still feel like we should crown a fork king in this thread.
we could crown
https://github.com/bradh/heif/tree/limits_header_2023-04-12
but maybe idc.

@bradh
Copy link
Author

bradh commented Feb 11, 2025

I don't think its worth maintaining a fork, because its not an important library. I don't think it is widely packaged, therefore not widely used.

If you want HEIF support, try https://github.com/strukturag/libheif/ (disclaimer - I'm a contributor to that project). If you just need AVIF support, try https://github.com/AOMediaCodec/libavif (disclaimer - I've contributed to that too).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants