set ngx.ctx.authenticated_groups if groups claim is present #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enables the use of Kong authorization plugins, such as the bundled "acl plugin Signed-off-by: Aron Parsons <[email protected]>
Logunov
approved these changes
Mar 4, 2020
|
|
|
Any chance @phirvone to get this merged? |
RaVbaker
suggested changes
Apr 24, 2020
| @@ -45,6 +45,10 @@ ngx.ctx.authenticated_consumer = { | |||
| } | |||
| ``` | |||
|
|
|||
| The plugin will try to retrieve the user's groups from a field in the token (default `groups`) | |||
| and set `ngx.ctx.authenticated_groups` so that Kong authorization plugins can make decisions | |||
There was a problem hiding this comment.
Suggested change
| and set `ngx.ctx.authenticated_groups` so that Kong authorization plugins can make decisions | |
| and set `kong.ctx.shared.authenticated_groups` so that Kong authorization plugins can make decisions |
| @@ -85,6 +86,12 @@ function M.injectUser(user) | |||
| ngx.req.set_header("X-Userinfo", ngx.encode_base64(userinfo)) | |||
| end | |||
|
|
|||
| function M.injectGroups(user, claim) | |||
| if user[claim] ~= nil then | |||
| ngx.ctx.authenticated_groups = user[claim] | |||
There was a problem hiding this comment.
Suggested change
| ngx.ctx.authenticated_groups = user[claim] | |
| kong.ctx.shared.authenticated_groups = user[claim] |
RaVbaker
referenced
this pull request
in revomatico/kong-oidc
Apr 24, 2020
|
Implemented in my fork, Revomatico/kong-oidc. I do not have this use case, so please test it and let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This inspects the token retrieved from the OIDC provider, checks if the
groupsclaim is present, and then sets the appropriate variable in the NGINX context so that other Kong plugins, such as the bundled ACL plugin can make authorization decisions based on the user's group vector.This is following up on @Trojan295's ask for adding more information to the context (#15 (comment)).