-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
draft-delegator-incentive-contract #90
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! Let's get this done first
.amount; | ||
let bot_desired_incentive = incentive_amount(&config); | ||
attributes.push(Attribute::new( | ||
"bot_incentive", | ||
bot_desired_incentive.to_string(), | ||
)); | ||
if contract_balance > bot_desired_incentive.amount { | ||
if delegator_contract_balance > bot_desired_incentive.amount { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of doing this check, we could make a message that does not fail when the delegator does not have enough balance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not fully sure how to do or if I understand correctly. if you could commit the change would be nice
… better but simonsays this is better
Great work! |
No description provided.