Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spectrum smoothing and autocorrelations #315

Merged
merged 16 commits into from
Oct 1, 2024
Merged

Conversation

mdenolle
Copy link
Collaborator

@mdenolle mdenolle commented Jul 5, 2024

  • smooth_N was used for spectral smoothing, it should be smoothspec_N
  • DC component should not be zero for autocorrelations

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.52%. Comparing base (337c737) to head (3e277a4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #315   +/-   ##
=======================================
  Coverage   83.52%   83.52%           
=======================================
  Files           9        9           
  Lines        1973     1973           
  Branches      332      332           
=======================================
  Hits         1648     1648           
  Misses        207      207           
  Partials      118      118           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Yiyu Ni <[email protected]>
Signed-off-by: Yiyu Ni <[email protected]>
Signed-off-by: Yiyu Ni <[email protected]>
Signed-off-by: Yiyu Ni <[email protected]>
@niyiyu niyiyu marked this pull request as ready for review October 1, 2024 19:56
@niyiyu niyiyu self-requested a review as a code owner October 1, 2024 19:56
@niyiyu niyiyu changed the title Marine test again fix: spectrum smoothing and autocorrelations Oct 1, 2024
@niyiyu niyiyu merged commit a1a2fc1 into main Oct 1, 2024
23 checks passed
@niyiyu niyiyu deleted the marine_test_again branch October 1, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants