-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-organization of tutorials #284
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #284 +/- ##
=======================================
Coverage 75.81% 75.81%
=======================================
Files 39 39
Lines 4425 4425
Branches 603 603
=======================================
Hits 3355 3355
Misses 925 925
Partials 145 145 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like some test .h5 got accidentally added and need to be removed. Once removed I suggest adding tutorials/asdf_data
to the .gitignore
Also, it's a best practice to clear the output of the notebooks before comitting them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See one more cleanup comment inline.
Also, can you give the PR a more descriptive name? When merging via "Squash and Merge" (preferred method), the PR title becomes the commit message in the history so its useful if it reflects the purpose of the PR. A good practice is to use the Conventional Commit format.
rearanged the TOC