Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-organization of tutorials #284

Merged
merged 10 commits into from
Feb 5, 2024
Merged

Re-organization of tutorials #284

merged 10 commits into from
Feb 5, 2024

Conversation

mdenolle
Copy link
Collaborator

rearanged the TOC

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d8ce19a) 75.81% compared to head (d7c8871) 75.81%.

❗ Current head d7c8871 differs from pull request most recent head 778e001. Consider uploading reports for the commit 778e001 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #284   +/-   ##
=======================================
  Coverage   75.81%   75.81%           
=======================================
  Files          39       39           
  Lines        4425     4425           
  Branches      603      603           
=======================================
  Hits         3355     3355           
  Misses        925      925           
  Partials      145      145           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@carlosgjs carlosgjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some test .h5 got accidentally added and need to be removed. Once removed I suggest adding tutorials/asdf_data to the .gitignore

Also, it's a best practice to clear the output of the notebooks before comitting them.

Copy link
Collaborator

@carlosgjs carlosgjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See one more cleanup comment inline.

Also, can you give the PR a more descriptive name? When merging via "Squash and Merge" (preferred method), the PR title becomes the commit message in the history so its useful if it reflects the purpose of the PR. A good practice is to use the Conventional Commit format.

tutorials/noisepy_scoped_download_s3_store.ipynb Outdated Show resolved Hide resolved
@mdenolle mdenolle changed the title Marine noisepy scoped Re-organization of tutorials Feb 4, 2024
@niyiyu niyiyu merged commit cea7c95 into main Feb 5, 2024
21 checks passed
@niyiyu niyiyu deleted the marine_noisepy_scoped branch February 5, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants