feat(performance): Always inline certain small methods#13
Merged
TomAFrench merged 2 commits intomainfrom Feb 13, 2025
Merged
Conversation
5 tasks
TomAFrench
reviewed
Feb 13, 2025
TomAFrench
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Part of general effort to reduce Brillig bytecode sizes and execution trace
Summary*
Certain small methods like
lshift8are called repeatedly but in fact do very little:These are the internals of
lshift8in an unconstrained context.We can avoid the function call overhead for this method that is itself only a few instructions and is likely to be simplified further as
shiftsis often a constant.Additional Context
PR Checklist*
cargo fmton default settings.