Skip to content

fix: don't cast numbers to bool #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asterite merged 1 commit into from
Jun 2, 2025
Merged

fix: don't cast numbers to bool #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/lib.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,10 +144,9 @@ where
fn conditional_select(lhs: Self, rhs: Self, predicate: bool) -> Self {
let x = bignum::bignum::conditional_select(lhs.x, rhs.x, predicate);
let y = bignum::bignum::conditional_select(lhs.y, rhs.y, predicate);
let is_infinity = (
(lhs.is_infinity as Field - rhs.is_infinity as Field) * predicate as Field
+ rhs.is_infinity as Field
) as bool;
let is_infinity = (lhs.is_infinity as Field - rhs.is_infinity as Field) * predicate as Field
+ rhs.is_infinity as Field;
let is_infinity = is_infinity != 0;
BigCurve { x, y, is_infinity }
}

Expand Down Expand Up @@ -344,7 +343,7 @@ where
y_out = bignum::bignum::conditional_select(B::zero(), y_out, infinity_predicate);

let conditional_select = |a: bool, b: bool, predicate: bool| {
((a as Field - b as Field) * predicate as Field + b as Field) as bool
((a as Field - b as Field) * predicate as Field + b as Field) != 0
};

let mut infinity_out = conditional_select(false, true, evaluate_group_operation_predicate);
Expand Down Expand Up @@ -451,7 +450,7 @@ where
y_out = bignum::bignum::conditional_select(B::zero(), y_out, infinity_predicate);

let conditional_select = |a: bool, b: bool, predicate: bool| {
((a as Field - b as Field) * predicate as Field + b as Field) as bool
((a as Field - b as Field) * predicate as Field + b as Field) != 0
};

let mut infinity_out = conditional_select(false, true, evaluate_group_operation_predicate);
Expand Down