fix: Update Tests#13
Merged
Merged
Conversation
Member
|
Looks like the issue is just from trying to run too many tests at once. I've made CI run these single-threaded for now to hopefully unblock this. |
TomAFrench
approved these changes
Nov 30, 2024
Merged
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove tests from
implblocks, dedupe test names.Additional Context
Tests now fail for
msmonSecp256r1,MNT6_753,MNT4_753, andSecp384r1curves. I'm unsure whatmsmmeans, but the error originates in theCurve::evaluate_linear_expressionmethod and fails in__compute_quadratic_expression_with_borrow_flagsfrom the noir-bignum library, specifically: