Skip to content

chore: Test PR 9772 [DO NOT MERGE]#9774

Closed
vezenovm wants to merge 4 commits intogd/acir-serialisation-changesfrom
mv/test-9772
Closed

chore: Test PR 9772 [DO NOT MERGE]#9774
vezenovm wants to merge 4 commits intogd/acir-serialisation-changesfrom
mv/test-9772

Conversation

@vezenovm
Copy link
Contributor

@vezenovm vezenovm commented Sep 9, 2025

Description

Problem*

Base #9772 off of #8134 which has the aztec-packages commit.

Summary*

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

vezenovm added a commit to AztecProtocol/aztec-packages that referenced this pull request Sep 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025

Changes to Brillig bytecode sizes

Generated at commit: f6ce18a44836378f9794ff2117ca6b1fe4629560, compared to commit: 93d2c57909cfaf65b7be2156ff607b156d5243a7

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
nested_dyn_array_regression_5782_inliner_max -12 ✅ -7.69%
nested_dyn_array_regression_5782_inliner_min -12 ✅ -7.69%
nested_dyn_array_regression_5782_inliner_zero -12 ✅ -7.69%

Full diff report 👇
Program Brillig opcodes (+/-) %
regression_5252_inliner_min 3,366 (-3) -0.09%
regression_5252_inliner_zero 3,217 (-3) -0.09%
poseidonsponge_x5_254_inliner_min 3,007 (-3) -0.10%
poseidonsponge_x5_254_inliner_zero 2,885 (-3) -0.10%
poseidon_bn254_hash_width_3_inliner_min 4,718 (-6) -0.13%
poseidon_bn254_hash_width_3_inliner_zero 4,421 (-6) -0.14%
poseidon_bn254_hash_width_3_inliner_max 4,812 (-24) -0.50%
fold_numeric_generic_poseidon_inliner_min 564 (-3) -0.53%
no_predicates_numeric_generic_poseidon_inliner_min 564 (-3) -0.53%
regression_5252_inliner_max 3,928 (-24) -0.61%
poseidonsponge_x5_254_inliner_max 3,644 (-24) -0.65%
wildcard_type_inliner_min 272 (-3) -1.09%
wildcard_type_inliner_max 262 (-3) -1.13%
wildcard_type_inliner_zero 262 (-3) -1.13%
simple_2d_array_inliner_min 130 (-6) -4.41%
nested_array_dynamic_inliner_max 1,546 (-92) -5.62%
nested_array_dynamic_inliner_min 1,332 (-92) -6.46%
nested_array_dynamic_inliner_zero 1,332 (-92) -6.46%
nested_dyn_array_regression_5782_inliner_max 144 (-12) -7.69%
nested_dyn_array_regression_5782_inliner_min 144 (-12) -7.69%
nested_dyn_array_regression_5782_inliner_zero 144 (-12) -7.69%

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025

Changes to number of Brillig opcodes executed

Generated at commit: f6ce18a44836378f9794ff2117ca6b1fe4629560, compared to commit: 93d2c57909cfaf65b7be2156ff607b156d5243a7

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
nested_dyn_array_regression_5782_inliner_max -12 ✅ -9.38%
nested_dyn_array_regression_5782_inliner_min -12 ✅ -9.38%
nested_dyn_array_regression_5782_inliner_zero -12 ✅ -9.38%

Full diff report 👇
Program Brillig opcodes (+/-) %
poseidon_bn254_hash_width_3_inliner_min 170,374 (-816) -0.48%
poseidon_bn254_hash_width_3_inliner_zero 166,907 (-816) -0.49%
poseidon_bn254_hash_width_3_inliner_max 136,376 (-816) -0.59%
poseidonsponge_x5_254_inliner_min 187,197 (-1,200) -0.64%
regression_5252_inliner_min 934,367 (-6,000) -0.64%
poseidonsponge_x5_254_inliner_zero 185,172 (-1,200) -0.64%
regression_5252_inliner_zero 921,840 (-6,000) -0.65%
poseidonsponge_x5_254_inliner_max 151,535 (-1,200) -0.79%
regression_5252_inliner_max 753,158 (-6,000) -0.79%
fold_numeric_generic_poseidon_inliner_min 4,571 (-60) -1.30%
no_predicates_numeric_generic_poseidon_inliner_min 4,571 (-60) -1.30%
wildcard_type_inliner_min 395 (-12) -2.95%
wildcard_type_inliner_max 381 (-12) -3.05%
wildcard_type_inliner_zero 381 (-12) -3.05%
nested_array_dynamic_inliner_min 2,734 (-92) -3.26%
nested_array_dynamic_inliner_zero 2,734 (-92) -3.26%
nested_array_dynamic_inliner_max 2,480 (-92) -3.58%
simple_2d_array_inliner_min 155 (-6) -3.73%
nested_dyn_array_regression_5782_inliner_max 116 (-12) -9.38%
nested_dyn_array_regression_5782_inliner_min 116 (-12) -9.38%
nested_dyn_array_regression_5782_inliner_zero 116 (-12) -9.38%

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: fe3a360 Previous: 1cc60bb Ratio
semaphore-depth-10 0.038 s 0.019 s 2

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@vezenovm vezenovm marked this pull request as draft September 9, 2025 02:08
@vezenovm vezenovm closed this Sep 9, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: fe3a360 Previous: 1cc60bb Ratio
test_report_zkpassport_noir_rsa_ 2 s 1 s 2

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant