fix: revert "feat: brillig functions can be pure if they are not entry points" (#9659)

[asterite]

Description

Problem

Aztec-Packages CI is failing: AztecProtocol/aztec-packages#16649

Summary

This isn't an exact revert as more changes were done to pure.rs, but it does revert the logic to consider brillig non-entrypoints as pure.

Additional Context

Documentation

Check one:

• No documentation needed.
• Documentation included in this PR.
• [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

• I have tested the changes locally.
• I have formatted the changes with Prettier and/or cargo fmt on default settings.

[github-actions]

Changes to number of Brillig opcodes executed

Generated at commit: 4033ccbab1a116c6d9f5d410d1d9c3c85bcdc653, compared to commit: 56325c40cf0a3986152c9b554cbab6ab97b4af4b

🧾 Summary (10% most significant diffs)

Program	Brillig opcodes (+/-)	%
regression_8739_inliner_min	+40 ❌	+222.22%
regression_8739_inliner_zero	+40 ❌	+222.22%

---

Full diff report 👇

Program	Brillig opcodes (+/-)	%
regression_8739_inliner_min	58 (+40)	+222.22%
regression_8739_inliner_zero	58 (+40)	+222.22%
closures_mut_ref_inliner_min	34 (+11)	+47.83%
closures_mut_ref_inliner_zero	34 (+11)	+47.83%
assign_ex_inliner_min	39 (+11)	+39.29%
assign_ex_inliner_zero	39 (+11)	+39.29%
reference_only_used_as_alias_inliner_min	250 (+13)	+5.49%
references_inliner_zero	326 (+11)	+3.49%
references_inliner_min	457 (+11)	+2.47%
uhashmap_inliner_min	174,340 (-48)	-0.03%
hashmap_inliner_min	79,946 (-48)	-0.06%

[github-actions]

Changes to Brillig bytecode sizes

Generated at commit: 4033ccbab1a116c6d9f5d410d1d9c3c85bcdc653, compared to commit: 56325c40cf0a3986152c9b554cbab6ab97b4af4b

🧾 Summary (10% most significant diffs)

Program	Brillig opcodes (+/-)	%
regression_8739_inliner_min	+39 ❌	+195.00%
regression_8739_inliner_zero	+39 ❌	+195.00%
closures_mut_ref_inliner_min	+7 ❌	+25.93%
closures_mut_ref_inliner_zero	+7 ❌	+25.93%

---

Full diff report 👇

Program	Brillig opcodes (+/-)	%
regression_8739_inliner_min	59 (+39)	+195.00%
regression_8739_inliner_zero	59 (+39)	+195.00%
closures_mut_ref_inliner_min	34 (+7)	+25.93%
closures_mut_ref_inliner_zero	34 (+7)	+25.93%
assign_ex_inliner_min	41 (+7)	+20.59%
assign_ex_inliner_zero	41 (+7)	+20.59%
reference_only_used_as_alias_inliner_min	223 (+9)	+4.21%
references_inliner_zero	215 (+7)	+3.37%
references_inliner_min	286 (+7)	+2.51%
hashmap_inliner_min	9,325 (+192)	+2.10%
array_sort_inliner_min	470 (+9)	+1.95%
uhashmap_inliner_min	7,425 (+136)	+1.87%

[github-actions]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: 8e6f0f9	Previous: 56325c4	Ratio
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_private-kernel-lib	248 s	206 s	1.20

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench