chore(ssa_fuzzer): refactor ssa_fuzzer part 2/4#9662
Merged
defkit merged 3 commits intosn/refactor_ssa_fuzzerfrom Sep 4, 2025
Merged
chore(ssa_fuzzer): refactor ssa_fuzzer part 2/4#9662defkit merged 3 commits intosn/refactor_ssa_fuzzerfrom
defkit merged 3 commits intosn/refactor_ssa_fuzzerfrom
Conversation
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: d2c1118 | Previous: 387b9b2 | Ratio |
|---|---|---|---|
test_report_noir-lang_sha512_ |
16 s |
13 s |
1.23 |
test_report_zkpassport_noir-ecdsa_ |
3 s |
2 s |
1.50 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
Rumata888
approved these changes
Sep 2, 2025
| } | ||
| } | ||
|
|
||
| // TODO |
Collaborator
There was a problem hiding this comment.
Remove or create an issue in the Noir repo and put the link here
| // god save me | ||
| // can be Reference(Array(Reference(Slice(Reference(Numeric))))) | ||
| // hope can handle it | ||
| fn generate_random_reference_type(rng: &mut StdRng, config: GenerateTypeConfig) -> Type { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Functions now can return references, arrays and slices
function_context.rsTypeinstead ofNumericTypefuzzer.rsget_return_value->get_return_values, returns all return witnesses, not just oneinstruction.rsbasic_tests.rsMutations
TypeTypecannot implementArbitrary.runner.rsbuilder.rsinsert_sliceProblem*
Resolves
Summary*
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.