feat: hoist safe casts from loops by TomAFrench · Pull Request #9645 · noir-lang/noir

TomAFrench · 2025-08-26T18:25:31Z

Description

Problem*

Resolves

Summary*

This PR experiments with hoisting upcasts more aggressively as described in #9644

Additional Context

Documentation*

Check one:

No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

github-actions · 2025-08-26T18:30:28Z

Changes to number of Brillig opcodes executed

Generated at commit: 863f99fcf04c6bd40f3436cacb25fec4ba982933, compared to commit: 585175e56f2c34f225fe6ac87a91f4962c61553d

🧾 Summary (10% most significant diffs)

Program	Brillig opcodes (+/-)	%
regression_5252_inliner_max	-240 ✅	-0.03%
higher_order_functions_inliner_zero	-20 ✅	-1.57%

Full diff report 👇

Program	Brillig opcodes (+/-)	%
poseidon_bn254_hash_width_3_inliner_zero	167,723 (-36)	-0.02%
poseidon_bn254_hash_width_3_inliner_min	171,190 (-40)	-0.02%
poseidon_bn254_hash_width_3_inliner_max	137,311 (-36)	-0.03%
poseidonsponge_x5_254_inliner_min	188,397 (-52)	-0.03%
regression_5252_inliner_min	940,337 (-260)	-0.03%
poseidonsponge_x5_254_inliner_zero	186,492 (-52)	-0.03%
regression_5252_inliner_zero	928,410 (-260)	-0.03%
poseidonsponge_x5_254_inliner_max	152,857 (-48)	-0.03%
regression_5252_inliner_max	759,768 (-240)	-0.03%
higher_order_functions_inliner_zero	1,256 (-20)	-1.57%

github-actions · 2025-08-26T18:30:38Z

Changes to Brillig bytecode sizes

Generated at commit: 863f99fcf04c6bd40f3436cacb25fec4ba982933, compared to commit: 585175e56f2c34f225fe6ac87a91f4962c61553d

🧾 Summary (10% most significant diffs)

Program	Brillig opcodes (+/-)	%
higher_order_functions_inliner_zero	-6 ✅	-0.82%

Full diff report 👇

Program	Brillig opcodes (+/-)	%
higher_order_functions_inliner_zero	726 (-6)	-0.82%

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `bfedb49`	Previous: `f30e342`	Ratio
`test_report_zkpassport_noir-ecdsa_`	`3` s	`2` s	`1.50`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

TomAFrench · 2025-08-28T12:20:50Z

This is another place where we'd benefit from #8645

Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore: remove duplicated frontend tests (noir-lang/noir#9706) chore: remove playwright workaround (noir-lang/noir#9704) fix(licm): Use `Loop::header` in `Loop::is_fully_executed` (noir-lang/noir#9700) chore: show which type is invalid as program input (noir-lang/noir#9701) chore: bump deps (noir-lang/noir#9698) chore: bump external pinned commits (noir-lang/noir#9693) chore(licm): Break things up further in LICM (noir-lang/noir#9683) chore(docs): spinning out bb docs (noir-lang/noir#9402) fix(ssa)!: Signed shift overflow checks rhs < bit_size (noir-lang/noir#9685) chore: add extra bitshifts tests (noir-lang/noir#9680) feat: Propagate purities using SCCs (noir-lang/noir#9672) chore: break `NodeInterner` into chunks (noir-lang/noir#9674) fix(formatter): don't revert indentation increase after popping it (noir-lang/noir#9673) feat: hoist safe casts from loops (noir-lang/noir#9645) chore: fix clippy warnings (noir-lang/noir#9675) chore(ssa): Refactor flattening (noir-lang/noir#9663) chore(ssa): Greenlight `brillig_entry_points` and switch to centralized CallGraph (noir-lang/noir#9668) chore: add two mem2reg regression tests where references are returned (noir-lang/noir#9670) fix(mem2reg): reuse existing expression and add missing alias (noir-lang/noir#9664) chore: add tests for bounded_vec (noir-lang/noir#9576) chore: redact debug info and file maps from snapshots (noir-lang/noir#9666) chore: pull out interpreter binary evaluation logic into pure functions (noir-lang/noir#9665) feat: brillig functions can be pure if they are not entry points (noir-lang/noir#9659) END_COMMIT_OVERRIDE Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>

Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore: remove duplicated frontend tests (noir-lang/noir#9706) chore: remove playwright workaround (noir-lang/noir#9704) fix(licm): Use `Loop::header` in `Loop::is_fully_executed` (noir-lang/noir#9700) chore: show which type is invalid as program input (noir-lang/noir#9701) chore: bump deps (noir-lang/noir#9698) chore: bump external pinned commits (noir-lang/noir#9693) chore(licm): Break things up further in LICM (noir-lang/noir#9683) chore(docs): spinning out bb docs (noir-lang/noir#9402) fix(ssa)!: Signed shift overflow checks rhs < bit_size (noir-lang/noir#9685) chore: add extra bitshifts tests (noir-lang/noir#9680) feat: Propagate purities using SCCs (noir-lang/noir#9672) chore: break `NodeInterner` into chunks (noir-lang/noir#9674) fix(formatter): don't revert indentation increase after popping it (noir-lang/noir#9673) feat: hoist safe casts from loops (noir-lang/noir#9645) chore: fix clippy warnings (noir-lang/noir#9675) chore(ssa): Refactor flattening (noir-lang/noir#9663) chore(ssa): Greenlight `brillig_entry_points` and switch to centralized CallGraph (noir-lang/noir#9668) chore: add two mem2reg regression tests where references are returned (noir-lang/noir#9670) fix(mem2reg): reuse existing expression and add missing alias (noir-lang/noir#9664) chore: add tests for bounded_vec (noir-lang/noir#9576) chore: redact debug info and file maps from snapshots (noir-lang/noir#9666) chore: pull out interpreter binary evaluation logic into pure functions (noir-lang/noir#9665) feat: brillig functions can be pure if they are not entry points (noir-lang/noir#9659) END_COMMIT_OVERRIDE

feat: hoist safe casts from loops

c0e8768

.

5389f02

github-actions bot reviewed Aug 26, 2025

View reviewed changes

Merge branch 'master' into tf/hoist-upcasts

bfedb49

TomAFrench marked this pull request as ready for review August 28, 2025 13:28

TomAFrench requested a review from a team August 28, 2025 13:28

asterite approved these changes Aug 28, 2025

View reviewed changes

Merge branch 'master' into tf/hoist-upcasts

5daa97c

TomAFrench enabled auto-merge August 29, 2025 11:18

TomAFrench added this pull request to the merge queue Aug 29, 2025

Merged via the queue into master with commit 318ff16 Aug 29, 2025
122 checks passed

TomAFrench deleted the tf/hoist-upcasts branch August 29, 2025 12:02

noirwhal mentioned this pull request Aug 29, 2025

chore: Release Noir(1.0.0-beta.12) #9565

Merged

AztecBot mentioned this pull request Aug 30, 2025

chore: Bump Noir reference AztecProtocol/aztec-packages#16649

Merged

TomAFrench mentioned this pull request Sep 4, 2025

Restrictions on hoisting casts seems overly restrictive. #9644

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: hoist safe casts from loops#9645

feat: hoist safe casts from loops#9645
TomAFrench merged 4 commits intomasterfrom
tf/hoist-upcasts

TomAFrench commented Aug 26, 2025

Uh oh!

github-actions bot commented Aug 26, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Aug 26, 2025 •

edited

Loading

Uh oh!

github-actions bot left a comment •

edited

Loading

Uh oh!

TomAFrench commented Aug 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

TomAFrench commented Aug 26, 2025

Description

Problem*

Summary*

Additional Context

Documentation*

PR Checklist*

Uh oh!

github-actions bot commented Aug 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes to number of Brillig opcodes executed

🧾 Summary (10% most significant diffs)

Uh oh!

github-actions bot commented Aug 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes to Brillig bytecode sizes

🧾 Summary (10% most significant diffs)

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

TomAFrench commented Aug 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Aug 26, 2025 •

edited

Loading

github-actions bot commented Aug 26, 2025 •

edited

Loading

github-actions bot left a comment •

edited

Loading