Skip to content

chore(mem2reg): avoid redundant PostOrder computation #9620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asterite merged 1 commit into from
Aug 25, 2025
Merged

chore(mem2reg): avoid redundant PostOrder computation #9620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions compiler/noirc_evaluator/src/ssa/opt/mem2reg.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ struct PerFunctionContext<'f> {
impl<'f> PerFunctionContext<'f> {
fn new(function: &'f mut Function) -> Self {
let cfg = ControlFlowGraph::with_function(function);
let post_order = PostOrder::with_function(function);
let post_order = PostOrder::with_cfg(&cfg);

PerFunctionContext {
cfg,
Expand All @@ -171,7 +171,7 @@ impl<'f> PerFunctionContext<'f> {
/// dom_tree were created from.
fn mem2reg(&mut self) {
// Iterate each block in reverse post order = forward order
let mut block_order = PostOrder::with_function(self.inserter.function).into_vec();
let mut block_order = self.post_order.as_slice().to_vec();
block_order.reverse();

for block in block_order {
Expand Down
Loading