feat: simplify bitshift logic to remove leftover overflow handling#9506
feat: simplify bitshift logic to remove leftover overflow handling#9506TomAFrench merged 11 commits intomasterfrom
Conversation
Changes to circuit sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 16ad037 | Previous: 12465f3 | Ratio |
|---|---|---|---|
test_report_zkpassport_noir_rsa_ |
1 s |
0 s |
+∞ |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: f121f90 | Previous: bae9236 | Ratio |
|---|---|---|---|
sha512-100-bytes |
2.013 s |
1.539 s |
1.31 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 68e6bad | Previous: 29160ca | Ratio |
|---|---|---|---|
private-kernel-inner |
0.017 s |
0.014 s |
1.21 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
d34f12c to
16ad037
Compare
Description
Problem*
Resolves
Summary*
After #9373, we still have some leftover logic where we're handling the potential for bitshifts greater than the type size. This PR removes some of those cases as well as doing a few simplifications to the
powfunction to reduce unnecessary DOFAdditional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.