fix(ssa): Replace unreachable array access with a constrain in Brillig#9378
Closed
fix(ssa): Replace unreachable array access with a constrain in Brillig#9378
Conversation
…lig, keep gate in ssa gen
…ate as only for ACIR
… mv/unreachable-array-access-constrain-trap
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 9b53a79 | Previous: 8146755 | Ratio |
|---|---|---|---|
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob |
185 s |
154 s |
1.20 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
Base automatically changed from
mv/gate-dummy-array-for-unreachable-array-get-set
to
master
August 1, 2025 18:22
…train-trap' into mv/unreachable-array-access-constrain-trap
…train-trap' into mv/unreachable-array-access-constrain-trap
This was referenced Sep 2, 2025
Contributor
Author
|
This is outdated. If we would like to handle Array Get/Set in Brillig in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Testing an alternative to #9376
Summary*
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.