fix: ignore implicit unbound named generic when searching trait impls#9350
Closed
fix: ignore implicit unbound named generic when searching trait impls#9350
Conversation
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 8f48b3f | Previous: 38997a8 | Ratio |
|---|---|---|---|
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_reset-kernel-lib |
2 s |
1 s |
2 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_rollup-lib |
4 s |
3 s |
1.33 |
test_report_zkpassport_noir-ecdsa_ |
3 s |
1 s |
3 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
5 tasks
Collaborator
Author
|
Closed in favor of #9352 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
Resolves #9168
Summary
I'm unsure about this change but in the small code snippet for the test the only thing that was failing was the trait impl lookup. This is the code:
When analyzing
impl Trait<Field> for i32we check ifField: Otherwe try to find an impl forFieldthat matchesOther<N = implicitly_added_named_generic>. It will then try to unify that implicitly added named generic with1and fail.Maybe an alternative is to replace those implicitly added named generics here with fresh type variables? In any case these bindings aren't committed in this lookup....
Additional Context
Documentation
Check one:
PR Checklist
cargo fmton default settings.