fix: modify ref count recursively for nested arrays#9341
Closed
fix: modify ref count recursively for nested arrays#9341
Conversation
Contributor
Changes to Brillig bytecode sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Contributor
|
Looks like we may need optimizations or explore alternate ways of fixing this. These brillig regressions seem prohibitive |
5 tasks
5 tasks
Contributor
Author
|
I will close this PR once #9347 is merged. |
Contributor
Author
|
closing because it is superseded by #9347 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #9270
Summary*
The ref count for Brillig array or slices is now modified recursively also on the inner arrays for nested arrays
Additional Context
This is a draft, because it is missing a test and I also want to update array-copy which also modifies the ref count, but not recursively yet.
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.