Skip to content

fix: don't assume default entry exists#9330

Merged
TomAFrench merged 3 commits intomasterfrom
ab/missing-main-error
Jan 2, 2026
Merged

fix: don't assume default entry exists#9330
TomAFrench merged 3 commits intomasterfrom
ab/missing-main-error

Conversation

@asterite
Copy link
Collaborator

@asterite asterite commented Jul 25, 2025

Description

Problem

Resolves #8749

Summary

This got broken in #8253 because a helper function was introduced to compile from stdin and assume the entry file exists, but that helper function was also used for regular compilation.

Additional Context

Documentation

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 110d287 Previous: f9553b6 Ratio
test_report_zkpassport_noir_rsa_ 2 s 1 s 2

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@asterite asterite requested a review from a team July 25, 2025 20:20
Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a huge fan of the extra argument but we can clean it up later.

@TomAFrench TomAFrench enabled auto-merge January 2, 2026 13:11
@TomAFrench TomAFrench added this pull request to the merge queue Jan 2, 2026
Merged via the queue into master with commit d8c37ea Jan 2, 2026
133 of 134 checks passed
@TomAFrench TomAFrench deleted the ab/missing-main-error branch January 2, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change missing main.nr error message

2 participants