fix: bind self when type-checking AsTraitPath#9236
Merged
Conversation
jfecher
approved these changes
Jul 17, 2025
Contributor
jfecher
left a comment
jfecher
left a comment
There was a problem hiding this comment.
LGTM - thank you
We should document how type bindings work for different ast nodes in general before auditing the elaborator
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 8159645 | Previous: c7ce62a | Ratio |
|---|---|---|---|
test_report_zkpassport_noir_rsa_ |
2 s |
1 s |
2 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 2eedc15 | Previous: c7ce62a | Ratio |
|---|---|---|---|
rollup-root |
0.005 s |
0.004 s |
1.25 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
github-merge-queue bot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 22, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE fix(SSA): validate MakeArray instruction (noir-lang/noir#9183) chore(docs): Add links to ACIR and source reference docs (noir-lang/noir#9260) fix: comptime code not mutating shared ref to struct field (noir-lang/noir#9250) fix(acir_gen): Bail out of `handle_constant_index` when it encounters `DynamicArray` (noir-lang/noir#9259) feat: allow paths in l-values (noir-lang/noir#9254) fix: parse AsTraitPath in type expressions (noir-lang/noir#9258) chore: add acir-gen unit tests per ssa instruction (2) (noir-lang/noir#9185) fix(licm): Ensure that all nested loops the current block is part of are guaranteed to execute (noir-lang/noir#9249) chore: bump external pinned commits (noir-lang/noir#9256) chore: enforce clippy in `ssa_fuzzer` (noir-lang/noir#9247) chore: clippy (noir-lang/noir#9246) chore: skip `ram_blowup_regression` on PRs (noir-lang/noir#9231) chore: mark bignum as expected to pass (noir-lang/noir#9244) fix: suggest traits via visible reexports if they are not directly visible (noir-lang/noir#9242) fix: bind self when type-checking AsTraitPath (noir-lang/noir#9236) chore(docs): Include list to hashing libraries at the top of the relevant docs page (noir-lang/noir#9239) fix(fuzz): Use scoping for variable dynamism (noir-lang/noir#9233) fix(ssa): Change constraint message to "multiply" (noir-lang/noir#9230) feat: Add `compiler_unstable_features` to `Nargo.toml` (noir-lang/noir#9219) chore(fuzz): Increase loop frequency in Brillig (noir-lang/noir#9228) chore: bump noir-edwards dep (noir-lang/noir#9229) END_COMMIT_OVERRIDE --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> Co-authored-by: Jan Beneš <janbenes1234@gmail.com>
github-merge-queue bot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 22, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE fix(SSA): validate MakeArray instruction (noir-lang/noir#9183) chore(docs): Add links to ACIR and source reference docs (noir-lang/noir#9260) fix: comptime code not mutating shared ref to struct field (noir-lang/noir#9250) fix(acir_gen): Bail out of `handle_constant_index` when it encounters `DynamicArray` (noir-lang/noir#9259) feat: allow paths in l-values (noir-lang/noir#9254) fix: parse AsTraitPath in type expressions (noir-lang/noir#9258) chore: add acir-gen unit tests per ssa instruction (2) (noir-lang/noir#9185) fix(licm): Ensure that all nested loops the current block is part of are guaranteed to execute (noir-lang/noir#9249) chore: bump external pinned commits (noir-lang/noir#9256) chore: enforce clippy in `ssa_fuzzer` (noir-lang/noir#9247) chore: clippy (noir-lang/noir#9246) chore: skip `ram_blowup_regression` on PRs (noir-lang/noir#9231) chore: mark bignum as expected to pass (noir-lang/noir#9244) fix: suggest traits via visible reexports if they are not directly visible (noir-lang/noir#9242) fix: bind self when type-checking AsTraitPath (noir-lang/noir#9236) chore(docs): Include list to hashing libraries at the top of the relevant docs page (noir-lang/noir#9239) fix(fuzz): Use scoping for variable dynamism (noir-lang/noir#9233) fix(ssa): Change constraint message to "multiply" (noir-lang/noir#9230) feat: Add `compiler_unstable_features` to `Nargo.toml` (noir-lang/noir#9219) chore(fuzz): Increase loop frequency in Brillig (noir-lang/noir#9228) chore: bump noir-edwards dep (noir-lang/noir#9229) END_COMMIT_OVERRIDE --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> Co-authored-by: Jan Beneš <janbenes1234@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
Resolves #9201
Summary
Additional Context
Documentation
Check one:
PR Checklist
cargo fmton default settings.