Skip to content

fix(ssa_fuzzer): fix panic if compiler removed return value #9216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomAFrench merged 2 commits into from
Jul 16, 2025
Merged

fix(ssa_fuzzer): fix panic if compiler removed return value #9216

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9901a3
fix
defkit Jul 16, 2025
e80bc02
fixing fix
defkit Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 27 additions & 15 deletions tooling/ssa_fuzzer/src/runner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,34 +29,46 @@ pub fn run_and_compare(

let return_witnesses_acir = &acir_program.functions[0].return_values;
let return_witnesses_brillig = &brillig_program.functions[0].return_values;
assert_eq!(return_witnesses_acir.0.len(), 1, "Multiple return value witnesses encountered");
assert_eq!(return_witnesses_brillig.0.len(), 1, "Multiple return value witnesses encountered");
let return_witness_acir: &Witness = return_witnesses_acir.0.first().unwrap();
let return_witness_brillig: &Witness = return_witnesses_brillig.0.first().unwrap();
assert!(return_witnesses_acir.0.len() <= 1, "Multiple return value witnesses encountered");
assert!(return_witnesses_brillig.0.len() <= 1, "Multiple return value witnesses encountered");
let return_witness_acir: Option<&Witness> = return_witnesses_acir.0.first();
let return_witness_brillig: Option<&Witness> = return_witnesses_brillig.0.first();

// we found bug in case of
// 1) acir_result != brillig_result
// 2) acir execution failed, brillig execution succeeded
// 3) acir execution succeeded, brillig execution failed
// it has depth 2, because nargo can panic or return NargoError
match (acir_result, brillig_result) {
(Ok(acir_result), Ok(brillig_result)) => {
let acir_result = acir_result[return_witness_acir];
let brillig_result = brillig_result[return_witness_brillig];
// we assume that if execution for both modes succeeds both programs returned something
let acir_result = acir_result[return_witness_acir.unwrap()];
let brillig_result = brillig_result[return_witness_brillig.unwrap()];
if acir_result == brillig_result {
CompareResults::Agree(acir_result)
} else {
CompareResults::Disagree(acir_result, brillig_result)
}
}
(Err(acir_error), Ok(brillig_result)) => {
let brillig_result = brillig_result[return_witness_brillig];
CompareResults::AcirFailed(acir_error.to_string(), brillig_result)
}
(Ok(acir_result), Err(brillig_error)) => {
let acir_result = acir_result[return_witness_acir];
CompareResults::BrilligFailed(brillig_error.to_string(), acir_result)
}
(Err(acir_error), Ok(brillig_result)) => match return_witness_brillig {
Some(return_witness) => {
let brillig_result = brillig_result[return_witness];
CompareResults::AcirFailed(acir_error.to_string(), brillig_result)
}
None => CompareResults::BothFailed(
acir_error.to_string(),
"Brillig program does not return anything".into(),
),
},
(Ok(acir_result), Err(brillig_error)) => match return_witness_acir {
Some(return_witness) => {
let acir_result = acir_result[return_witness];
CompareResults::BrilligFailed(brillig_error.to_string(), acir_result)
}
None => CompareResults::BothFailed(
"ACIR program does not return anything".into(),
brillig_error.to_string(),
),
},
(Err(acir_error), Err(brillig_error)) => {
CompareResults::BothFailed(acir_error.to_string(), brillig_error.to_string())
}
Expand Down
Loading