fix(fuzz): Do not access arrays with &mut inside if using dynamic condition#9072
Merged
fix(fuzz): Do not access arrays with &mut inside if using dynamic condition#9072
&mut inside if using dynamic condition#9072Conversation
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: c6d667a | Previous: 441f39a | Ratio |
|---|---|---|---|
test_report_zkpassport_noir_rsa_ |
1 s |
0 s |
+∞ |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
vezenovm
approved these changes
Jul 1, 2025
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: ca0f12b | Previous: 077bb6d | Ratio |
|---|---|---|---|
rollup-block-root-single-tx |
227 s |
185 s |
1.23 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
asterite
reviewed
Jul 2, 2025
asterite
approved these changes
Jul 2, 2025
Collaborator
asterite
left a comment
There was a problem hiding this comment.
Looks good! I left a question but it's likely me misunderstanding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #9035
Summary*
in_dynamicflag to the AST generator which is turned on when we are inside the then or the else of anifstatement where the condition is using a dynamic variable. Under such circumstances anything we do inside is under some predicate that will tie the outcome to the circuit inputs in ACIR.in_dynamicregion.Waiting on #9047
Additional Context
Instead of panicking on leftover loads, we can defer it to runtime using #8943
Or we can keep panicking and try to turn those panics into better user errors, like the
verify_no_dynamic_indices_to_references, once we have examples of them.Documentation*
Check one:
PR Checklist*
cargo fmton default settings.