chore: Switch to rustc-hash by jfecher · Pull Request #9064 · noir-lang/noir

jfecher · 2025-06-30T17:49:00Z

Description

Problem*

We depend on fxhash which is no longer maintained and has been superseded by rustc-hash

Summary*

This PR:

Replaces uses of fxhash with rustc-hash
Adds util::hash64 to provide a utility function missing from rustc-hash which we use in several crates.

Additional Context

Documentation*

Check one:

No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `fd66013`	Previous: `11e956e`	Ratio
`test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob`	`186` s	`143` s	`1.30`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

jfecher · 2025-06-30T19:15:55Z

Seems like some fairly large test suite duration regressions

vezenovm · 2025-06-30T19:45:41Z

Seems like some fairly large test suite duration regressions

Some of these times such as for aztec-nr and types seem to line up with what I see in my PR #9060 (review). Makes me think that perhaps something else is up.

vezenovm · 2025-07-01T08:43:13Z

Some of these times such as for aztec-nr and types seem to line up with what I see in my PR #9060 (review). Makes me think that perhaps something else is up.

Yeah something is definitely up with the alerts #9068 (review). I am very surprised to see an alert on #9068. cc @TomAFrench

TomAFrench · 2025-07-01T08:47:29Z

I was just taking a look at this. I'm not entirely sure what's up as there's been no bumps to the pinned commit in the period from when these branches were made.

TomAFrench · 2025-07-01T08:50:22Z

Huh, actually it looks like it's using a commit from ~2 weeks ago as the baseline.

TomAFrench · 2025-07-01T09:09:16Z

@vezenovm the fix is in #9069

github-actions

ACVM Benchmarks

Details

Benchmark suite	Current: `63818f4`	Previous: `d356b92`	Ratio
`purely_sequential_opcodes`	`252031` ns/iter (`± 811`)	`251347` ns/iter (`± 1144`)	`1.00`
`perfectly_parallel_opcodes`	`220103` ns/iter (`± 2297`)	`220657` ns/iter (`± 1306`)	`1.00`
`perfectly_parallel_batch_inversion_opcodes`	`2783531` ns/iter (`± 1155`)	`2784923` ns/iter (`± 5526`)	`1.00`

This comment was automatically generated by workflow using github-action-benchmark.

github-actions

Compilation Time

Details

Benchmark suite	Current: `63818f4`	Previous: `d356b92`	Ratio
`private-kernel-inner`	`2.488` s	`2.464` s	`1.01`
`private-kernel-reset`	`8.214` s	`8.052` s	`1.02`
`private-kernel-tail`	`1.15` s	`1.168` s	`0.98`
`rollup-base-private`	`18.6` s	`18.06` s	`1.03`
`rollup-base-public`	`14.78` s	`15.18` s	`0.97`
`rollup-block-root-empty`	`21.48` s	`21.2` s	`1.01`
`rollup-block-root-single-tx`	`203` s	`200` s	`1.01`
`rollup-block-root`	`197` s	`205` s	`0.96`
`rollup-merge`	`1.292` s	`1.32` s	`0.98`
`rollup-root`	`1.402` s	`1.458` s	`0.96`
`semaphore-depth-10`	`0.764` s	`0.784` s	`0.97`

This comment was automatically generated by workflow using github-action-benchmark.

github-actions

Artifact Size

Details

Benchmark suite	Current: `63818f4`	Previous: `d356b92`	Ratio
`private-kernel-inner`	`1127.4` KB	`1127.4` KB	`1`
`private-kernel-reset`	`2068` KB	`2067.9` KB	`1.00`
`private-kernel-tail`	`585` KB	`585` KB	`1`
`rollup-base-private`	`4934.4` KB	`4934.4` KB	`1`
`rollup-base-public`	`3975.6` KB	`3975.6` KB	`1`
`rollup-block-root-empty`	`3871.1` KB	`3871.1` KB	`1`
`rollup-block-root-single-tx`	`32733.4` KB	`32733.4` KB	`1`
`rollup-block-root`	`32752.7` KB	`32752.7` KB	`1`
`rollup-merge`	`176.8` KB	`176.8` KB	`1`
`rollup-root`	`389.5` KB	`389.5` KB	`1`
`semaphore-depth-10`	`636.4` KB	`636.4` KB	`1`

This comment was automatically generated by workflow using github-action-benchmark.

github-actions

Execution Time

Details

Benchmark suite	Current: `63818f4`	Previous: `d356b92`	Ratio
`private-kernel-inner`	`0.025` s	`0.026` s	`0.96`
`private-kernel-reset`	`0.161` s	`0.161` s	`1`
`private-kernel-tail`	`0.01` s	`0.011` s	`0.91`
`rollup-base-private`	`0.297` s	`0.295` s	`1.01`
`rollup-base-public`	`0.18` s	`0.184` s	`0.98`
`rollup-block-root`	`12.9` s	`13.4` s	`0.96`
`rollup-merge`	`0.003` s	`0.002` s	`1.50`
`rollup-root`	`0.004` s	`0.004` s	`1`
`semaphore-depth-10`	`0.019` s	`0.02` s	`0.95`

This comment was automatically generated by workflow using github-action-benchmark.

github-actions

Test Suite Duration

Details

Benchmark suite	Current: `63818f4`	Previous: `d356b92`	Ratio
`test_report_AztecProtocol_aztec-packages_noir-projects_aztec-nr`	`100` s	`101` s	`0.99`
`test_report_AztecProtocol_aztec-packages_noir-projects_noir-contracts`	`146` s	`155` s	`0.94`
`test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob`	`179` s	`185` s	`0.97`
`test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_private-kernel-lib`	`219` s	`221` s	`0.99`
`test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_rollup-lib`	`640` s	`713` s	`0.90`
`test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_types`	`93` s	`93` s	`1`
`test_report_noir-lang_noir-bignum_`	`380` s	`378` s	`1.01`
`test_report_noir-lang_noir_bigcurve_`	`273` s	`269` s	`1.01`
`test_report_noir-lang_sha512_`	`17` s	`15` s	`1.13`
`test_report_zkpassport_noir-ecdsa_`	`119` s	`116` s	`1.03`
`test_report_zkpassport_noir_rsa_`	`2` s	`2` s	`1`

This comment was automatically generated by workflow using github-action-benchmark.

github-actions

Execution Memory

Details

Benchmark suite	Current: `63818f4`	Previous: `d356b92`	Ratio
`private-kernel-inner`	`202.71` MB	`202.71` MB	`1`
`private-kernel-reset`	`226.5` MB	`226.5` MB	`1`
`private-kernel-tail`	`178.04` MB	`178.04` MB	`1`
`rollup-base-private`	`508.01` MB	`508.01` MB	`1`
`rollup-base-public`	`441.22` MB	`441.22` MB	`1`
`rollup-block-root`	`1510` MB	`1510` MB	`1`
`rollup-merge`	`330.09` MB	`330.09` MB	`1`
`rollup-root`	`332.7` MB	`332.7` MB	`1`
`semaphore_depth_10`	`71.01` MB	`71.01` MB	`1`

This comment was automatically generated by workflow using github-action-benchmark.

github-actions

Compilation Memory

Details

Benchmark suite	Current: `63818f4`	Previous: `d356b92`	Ratio
`private-kernel-inner`	`280.11` MB	`280.19` MB	`1.00`
`private-kernel-reset`	`534.01` MB	`534.01` MB	`1`
`private-kernel-tail`	`184.58` MB	`184.58` MB	`1`
`rollup-base-private`	`1400` MB	`1400` MB	`1`
`rollup-base-public`	`1530` MB	`1530` MB	`1`
`rollup-block-root-empty`	`1090` MB	`1090` MB	`1`
`rollup-block-root-single-tx`	`9380` MB	`9380` MB	`1`
`rollup-block-root`	`9390` MB	`9390` MB	`1`
`rollup-merge`	`333.56` MB	`333.56` MB	`1`
`rollup-root`	`343.6` MB	`343.6` MB	`1`
`semaphore_depth_10`	`106.39` MB	`106.39` MB	`1`

This comment was automatically generated by workflow using github-action-benchmark.

Cargo.toml

utils/hash64/src/lib.rs

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `63818f4`	Previous: `d356b92`	Ratio
`rollup-merge`	`0.003` s	`0.002` s	`1.50`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

TomAFrench · 2025-09-08T09:46:24Z

Closing this as I've made this change in #9750

jfecher added 2 commits June 30, 2025 12:32

Switch to rustc-hash

ee97811

snap files oh my

dc4c836

jfecher requested a review from a team June 30, 2025 17:49

jfecher added 3 commits June 30, 2025 12:56

Remove remaining referencecs to fxhash in tests

816c485

Format

8074892

Update test dependency in acir

c3326ac

vezenovm approved these changes Jun 30, 2025

View reviewed changes

Update snap

8f90971

github-actions bot reviewed Jun 30, 2025

View reviewed changes

jfecher added the bench-show Display benchmark results on PR label Jun 30, 2025

vezenovm mentioned this pull request Jun 30, 2025

fix(ssa): Do not fail for static assertions in a map over empty dynamic slices #9060

Merged

5 tasks

Merge branch 'master' into jf/rustc-hash

dae6e05

github-actions bot reviewed Jul 1, 2025

View reviewed changes

TomAFrench reviewed Jul 1, 2025

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

TomAFrench added 2 commits July 1, 2025 15:06

chore: fix cargo.toml

deef229

chore: use BuildHasher in hash64 crate

f5edbf4

TomAFrench reviewed Jul 1, 2025

View reviewed changes

utils/hash64/src/lib.rs Show resolved Hide resolved

Remove hash64 util crate

2cb2175

jfecher added 2 commits July 1, 2025 11:49

Merge snap changes

095299a

Format

f81bf97

jfecher enabled auto-merge July 1, 2025 16:57

jfecher and others added 4 commits July 1, 2025 15:11

Clippy

01676f8

Merge branch 'master' into jf/rustc-hash

fd66013

Snap conflicts

dc0582f

Format

63818f4

github-actions bot reviewed Jul 2, 2025

View reviewed changes

TomAFrench mentioned this pull request Sep 8, 2025

chore: migrate away from fxhash to address advisory #9750

Merged

5 tasks

TomAFrench closed this Sep 8, 2025

auto-merge was automatically disabled September 8, 2025 09:46
Pull request was closed

Conversation

jfecher commented Jun 30, 2025

Description

Problem*

Summary*

Additional Context

Documentation*

PR Checklist*

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

jfecher commented Jun 30, 2025

Uh oh!

vezenovm commented Jun 30, 2025

Uh oh!

vezenovm commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TomAFrench commented Jul 1, 2025

Uh oh!

TomAFrench commented Jul 1, 2025

Uh oh!

TomAFrench commented Jul 1, 2025

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

ACVM Benchmarks

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Compilation Time

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Artifact Size

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Execution Time

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Test Suite Duration

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Execution Memory

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Compilation Memory

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

TomAFrench commented Sep 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot left a comment •

edited

Loading

vezenovm commented Jul 1, 2025 •

edited

Loading

github-actions bot left a comment •

edited

Loading

github-actions bot left a comment •

edited

Loading

github-actions bot left a comment •

edited

Loading

github-actions bot left a comment •

edited

Loading

github-actions bot left a comment •

edited

Loading

github-actions bot left a comment •

edited

Loading

github-actions bot left a comment •

edited

Loading